modoboa / modoboa-installer

An installer for Modoboa
MIT License
258 stars 135 forks source link

modoboa installer doesn't work on lmde 6 #529

Closed aleczdr closed 5 months ago

aleczdr commented 11 months ago

Impacted versions

latest

Steps to reproduce

run modoboa installer following documentation crashes and says operating system not supported

Full trace using --debug option or current behaviour

raises a not implemented error and says the distribution isnt supported.

Expected behavior

installer installs modoboa on a debian-based system

Video/Screenshot link (optional)

aleczdr commented 11 months ago

i got it to work by editing package.py and forcing the output of get_backend() to debian

tonioo commented 10 months ago

@aleczdr That's a good news. Could you provide a PR?

aleczdr commented 10 months ago

@tonioo sorry for the late reply I don't think a PR should be used here as what I did was force the installer to always think it's compatible by disregarding the compatibility check entirely. The real solution would be to add LMDE to the list of compatible systems, which I didn't do because I needed to get modoboa working quickly.

I did first try adding LMDE, Linux Mint, Mint, and other strings to the list of distros within package.py but I couldn't get it to work, which is the other reason why I resorted to the quick and dirty method.

Spitfireap commented 9 months ago

@aleczdr could post the output of cat /etc/os-release on LMDE please :) ?

aleczdr commented 9 months ago

@Spitfireap here you go

PRETTY_NAME="LMDE 6 (faye)"
NAME="LMDE"
VERSION_ID="6"
VERSION="6 (faye)"
VERSION_CODENAME=faye
ID=linuxmint
HOME_URL="https://www.linuxmint.com/"
SUPPORT_URL="https://forums.linuxmint.com/"
BUG_REPORT_URL="http://linuxmint-troubleshooting-guide.readthedocs.io/en/latest/"
PRIVACY_POLICY_URL="https://www.linuxmint.com/"
ID_LIKE=debian
DEBIAN_CODENAME=bookworm

Besides adding LMDE (and hopefully regular Mint as well) to the list of supported systems, it would be a good idea for Modoboa to also interpret the ID_LIKE value as there are other systems out there that are also based on Debian and probably have this value.

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aleczdr commented 6 months ago

PR #548