search

modoboa / modoboa-stats

Graphical statistics for Modoboa
MIT License
9 stars 12 forks source link

Fully integrate alias domains #22

Closed mundschenk-at closed 7 years ago

mundschenk-at commented 7 years ago

The PR also adds code to explicitly ignore unknown RRD data and adds tags for all debug messages. Both of these commits are probably not strictly necessary, so I'm open to dropping them.

mundschenk-at commented 7 years ago

@tonioo I'll continue working on the other issues/PRs once this one has been successfully merged.

mundschenk-at commented 7 years ago

@tonioo Regarding single quotes: I'll replace them, I just didn't want to touch existing lines only for that reason.

tonioo commented 7 years ago

@mundschenk-at ok thanks. Have you seen the other comments I made?

mundschenk-at commented 7 years ago

@tonioo Yes. I'll replace the domain method with split_mailbox tonight. I didn't get around to it yesterday because the return signature necessitates a few more changes. All others are in, except for the getattr call. While very elegant, I'm not totaly convinced. There might be routines that should not depend the prog (i.e. "try with this method, if it fails, try another one")? Or maybe that's too complicated thinking.

tonioo commented 7 years ago

According to your current code, my proposal is fine. If you want a "try and guess" mechanism, then it won't work.

mundschenk-at commented 7 years ago

Yeah, I was wondering if we might need such a mechanism. But then again, the parser is looking at individual lines, so having a "try and guess" mechanism is of doubtful usability. Also, a "guessing" parser function could just call another method if necessary.

tonioo commented 7 years ago

@mundschenk-at great! Thank you for your work.