search

modoboa / modoboa

Mail hosting made simple
https://modoboa.org
ISC License
3.06k stars 401 forks source link

django-ckeditor bundles CKEditor 4.22.1 isn't supported anymore #3316

Open bosgold opened 2 months ago

bosgold commented 2 months ago

Impacted versions

Steps to reproduce

Starting the upgrade procedure to Modoboa 2.3.1. Including the by pip desired upgrade of pip during this procedure.

Current behavior

Upgrade as such was successfull. But all cronjobs " $PYTHON $INSTANCE/manage.py ..." throw out a warning message

System check identified some issues:

WARNINGS: ?: (ckeditor.W001) django-ckeditor bundles CKEditor 4.22.1 which isn't supported anmyore and which does have unfixed security issues, see for example https://ckeditor.com/cke4/release/CKEditor-4.24.0-LTS . You should consider strongly switching to a different editor (maybe CKEditor 5 respectively django-ckeditor-5 after checking whether the CKEditor 5 license terms work for you) or switch to the non-free CKEditor 4 LTS package. See https://ckeditor.com/ckeditor-4-support/ for more on this. (Note! This notice has been added by the django-ckeditor developers and we are not affiliated with CKSource and were not involved in the licensing change, so please refrain from complaining to us. Thanks.)

Expected behavior

No such warnings. Besides redirecting the cronjob warnings/errors to /dev/null. Don't think this is a good idea.

belzebub40k commented 2 months ago

Seems to be a known upstream issue with no real fix but you can silence the warning via SILENCED_SYSTEM_CHECKS in settings.py.

https://github.com/django-ckeditor/django-ckeditor/issues/764

SILENCED_SYSTEM_CHECKS = [
    ...
    "ckeditor.W001",  # CKEditor 4.22.1 warning
]
VladlenO commented 1 month ago

Seems to be a known upstream issue with no real fix but you can silence the warning via SILENCED_SYSTEM_CHECKS in settings.py.

django-ckeditor/django-ckeditor#764

SILENCED_SYSTEM_CHECKS = [
    ...
    "ckeditor.W001",  # CKEditor 4.22.1 warning
]

In which file exactly should I specify the prohibition on updating? Thanks.

belzebub40k commented 1 month ago

@VladlenO in the settings.py of your modoboa instance. There should already be a section SILENCED_SYSTEM_CHECKS. It does not prohibit any updates it only silences the warning.

renarios commented 3 days ago

Is it possible to just install django-ckeditor-5, or does the configuration of modoboa have to be changed for that?

bosgold commented 3 days ago

Replacing CKEditor 4 by django-ckeditor 5 does not work. Some of the things I already tried.