search

modocache / Guanaco

Nimble matchers for LlamaKit.
MIT License
22 stars 6 forks source link

Updating to use Nimble Predicate #17

Open ishaanSejwal opened 6 years ago

ishaanSejwal commented 6 years ago

Hey @modocache I was checking on you if this is the only way to match Result objects or some other process is being used by community that I am unaware of. If the former is the case, would you be willing to review a PR for updating Guanaco to use Nimble v7 with Predicate and PredicateResult

Thanks and have a great day!

ishaanSejwal commented 6 years ago

@mattrubin

m3ta4a commented 6 years ago

This sounds necessary in order to use Guanaco in Nimble version 7.x, but unfortunately I don't really understand the differences between Predicate and NonNilMatcherFunc well enough to put together a PR. Nimble is apparently using Predicate but Guanaco is still using NonNilMatcherFunc and swapping them out looks nontrivial. If anyone could help it would be much appreciated, otherwise I'll continue looking into it and hope to understand the problem better. @modocache @mattrubin

ishaanSejwal commented 6 years ago

@jakeva I have actually made some changes to both Nimble and Guanaco so that I can use it with SPM some months ago, since Nimble was fully SPM compliant, I did changes to Guanaco to bring it forward to accommodate those changes, this includes using Predicate: https://github.com/ishaanSejwal/Guanaco/tree/SPM https://github.com/ishaanSejwal/Nimble/tree/PredicateResultChanges