search

modolabs / Kurogo-Mobile-Web

Kurogo is a PHP framework for delivering high quality, data driven customizable content to a wide range of mobile devices. Its strengths lie in the customizable system that allows you to adapt content from a variety of sources and easily present that to mobile devices from feature phones, to early generation smart phones, to modern devices and tablets
http://kurogo.org
GNU Lesser General Public License v2.1
198 stars 99 forks source link

Admin, Maps, and Dateformatter #52

Open nchutchind opened 12 years ago

nchutchind commented 12 years ago

I'm not familiar with github or git, so I hope I'm doing this right.

Removed break that was causing Maps to display an infowindow by default no matter how many placemarks were added.

Modified Admin module css and js to allow for dynamic groups that extend to more than one line to fit without overlapping content. Add several groups to the Maps app to see this.

Modified the DateFormatter to allow for defining and passing in your own patterns. If the parameter you pass in is non-numeric, then we don't bother looking at the preset constants and instead use whatever pattern was passed in.

Changed GoogleJSMap to get the Description from the KML file since there is no subtitle entry. Also changed several occurrences of misnamed variables.

nchutchind commented 12 years ago

Ok, so you're saying that, if the KML file has a <snippet> entry, the app will use that?

Where should we go from here? Should I change back the "description" change I made and recommit?

nchutchind commented 12 years ago

I apologize if I'm doing this wrong. :) This is my first foray into open source development, as well as git and github in general.

sonya commented 12 years ago

Hi, I didn't realize GitHub didn't give notifications for replies to comments, so apologies about the late reply. Thanks for the new commit.

I think what you're doing is cool, but it might be easier on us in the future if each pull request contains changes to just one module or library, as we track them independently (although I think GitHub won't let you have multiple pull requests on the same repo, so that is a limitation we have to live with).