`com.modrinth.theseus` file path breaks structure NBT saving in Minecraft

TelepathicGrunt commented 4 months ago

Describe the bug

Vanilla Minecraft has a bug that affected many Minecraft versions. This bug was originally found on 1.20.4 Minecraft but likely exists for a large number of older versions. The bug is Vanilla has a regex that will reject any file path that has a folder name starting with com. and the Modrinth app creates a folder called com.modrinth.theseus

This means trying to save structures to NBT files using the Structure Block in game will fail and break. Any mod using the vanilla method to save an area into NBT files will also be broken. Example, Bumblezone's Essence Arenas will fail to start since they cannot save the pre-arena area to NBT anymore when using Modrinth app.

Steps to reproduce

\give @s structure_block
Place the structure block down
Open the Structure Block's GUI by right clicking it
Put it in Save mode with size of 1 for all dimensions.
Give it the name test.
Try hitting save.
Will say it is unable to save the structure in chat.

How to use Structure Blocks: https://www.youtube.com/watch?v=umhuRXinD3o

Expected behavior

Saving structures to nbt files should work with vanilla Minecraft with no mods on when using Modrinth App

System information

This is on Windows OS.

Additional context

Quick solution probably is to rename the folder path to just modrinth.theseus or something idk

TelepathicGrunt commented 3 months ago

Jira issue report: https://bugs.mojang.com/browse/MC-268617

TheD0ct0r101 commented 2 months ago

Hope we dont ignore this because I can confirm. The problem persists in 1.17.1.

modrinth / code