modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
767 stars 124 forks source link

Mods losing metadata after being udpated #1085

Open MrMiumo opened 3 months ago

MrMiumo commented 3 months ago

Describe the bug

After updating some mods, they became "unlinked" from modrinth. In the content tab of the profile, they no longer have any image, description or link. image

Steps to reproduce

  1. Find a mod which has a new version to update to
  2. Click the update button (or go the the versions tab and switch to the latest)
  3. Observe that the pack has disappear from the content tab, and is now at the end of the list, without its metadata

Expected behavior

When updating a mod, it should not lost its metadata !

System information

Windows 11 23H2 Theseus v0.6.3 Fabric 1.20.4 Jdk 17

Additional context

After taking a look at the issue, it seems that it is in the profile.json file. The mod entry no longer have its "metadata" tag filled correctly:

Before updating

        "mods\\modernfix-fabric-5.14.0+mc1.20.4.jar": {
            "sha512": "3e01e37697c90971cf36f25dc281ba0f96ccae18",
            "disabled": false,
            "metadata": {
                "type": "modrinth",
                "project": {
                    "id": "nmDcB62a",
                    "slug": "modernfix",
                    "project_type": "mod",
                    "team": "xw684WUq",
                    "title": "ModernFix",
                    "description": "All-in-one mod that improves performance, reduces memory usage, and fixes many bugs. Compatible with all your favorite performance mods!",
                    "body": "![Banner image](https://cdn-raw.modrinth.com/data/nmDcB62a/images/3c7be090404ebfed497b04aec8b4cd7cc1aac7ca.png)\n\n[![Donate](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/donate/kofi-singular_vector.svg)](https://ko-fi.com/embeddedt)\n[![Available for Fabric](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/supported/fabric_vector.svg)](https://modrinth.com/mod/modernfix/versions?l=fabric)\n[![Available for Forge](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/supported/forge_vector.svg)](https://modrinth.com/mod/modernfix/versions?l=forge)\n[![Join the Discord](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/social/discord-plural_vector.svg)](https://discord.gg/rN9Y7caguP)\n\nModernFix is an all-in-one mod that **improves performance, reduces memory usage, and fixes many bugs** in modern Minecraft versions (most versions including and above 1.16 are supported)\nwithout majorly compromising the game experience. Most Forge 1.16-1.19.2 modpacks will launch **roughly twice as fast** with ModernFix installed.\nIf some non-default options are enabled, it can even allow large modpacks like All The Mods 8 to run with **3GB or less of allocated memory**.\n\nModernFix is free, open-source software. All of the code is available on [the GitHub repository](https://github.com/embeddedt/ModernFix).\n\n## ⚙️ Technical summary\n\nWhat exactly does ModernFix do for your game? There are a lot of tweaks being made - too many to summarize here. However, here is a\nbrief summary of the general types of improvements being made:\n\n* Backports of bugfixes from newer versions of Minecraft and/or Forge, e.g. fixing\n[worlds breaking when you remove a dimension mod in 1.18](https://github.com/MinecraftForge/MinecraftForge/issues/8800).\n* Patches to mods that are no longer supported on a given Minecraft version, to improve the gameplay experience instead of requiring\nplayers to update.\n* Many optimizations & improvements to the game's launch process to significantly improve speed and reduce random concurrency crashes.\n* Additional debug tools to help modders and players determine the cause of some rare game crashes/freezes, instead of relying on a painful\nmod bisection process.\n* It's not enabled by default due to compatibility issues, but ModernFix includes functionality to [completely redesign the game's model loading system](https://github.com/embeddedt/ModernFix/wiki/Dynamic-Resources-FAQ), replacing it with a new,\ndynamic version that loads models on the fly. Model loading is one of the major performance regressions to modded Minecraft that\nhas been present since 1.8, and this new system alleviates nearly all of the downsides, bringing memory usage and loading times\nmore in line with how they were in 1.7.10.\n* Need to play the game with very little RAM allocated (e.g. 512MB or less)? [Now you can do that.](https://github.com/embeddedt/ModernFix/wiki/Ultra%E2%80%90Low-Memory-Footprint)\n\nIf you are technically savvy and looking for more details on each patch, I recommend reading the [Summary of Patches](https://github.com/embeddedt/ModernFix/wiki/Summary-of-Patches) wiki page.\n\n## 🐛 Where to go when something doesn't work\n\nPlease either report an issue on [GitHub](https://github.com/embeddedt/ModernFix), or join the [Discord](https://discord.gg/rN9Y7caguP) and ask in the `#modernfix-discussion` channel.\nBe sure to mention the Minecraft version, modloader, and ModernFix version you are using, as well as what other mods you have installed.\n\n## 🎁 How can I support this project?\n\nThere are two main ways you can help support the development of ModernFix:\n\n* Spread the word! Test ModernFix in modpacks and encourage them to include it.\n* If you feel generous, I do accept donations via [Ko-fi](https://ko-fi.com/embeddedt). Donating is not required (as ModernFix is free),\nbut every little bit helps. I work on ModernFix in my spare time, so any compensation I receive helps to sustain development.\n\n## ❓ What other mods should I use?\n\nThere are many performance mods available for Minecraft and I can't list them all here, but here are some essential mods, in my opinion:\n\n- On any version before 1.19.4 you should always have LazyDFU installed, as it eliminates the incredible lag caused by the DFU system.\n- On any version before 1.20 you should generally use Starlight unless it has a compatibility issue with your mods (which is quite rare).\nIt offers vastly improved lighting performance and can also fix FPS stutters when moving between chunks.\n- Always have FerriteCore installed, as Mojang's implementation of blockstates/models is laughably inefficient, and quickly\nconsumes RAM as soon as more content is added beyond what vanilla offers.\n- Install a mod like Shutup Experimental settings (before 1.19) or Yeetus Experimentus (1.19+). These mods will suppress the\npop-up screen about experimental game features, which otherwise causes the game to reload its resources twice.\n\nOn a related note: I do **not** recommend use of OptiFine in any modded scenario. It is closed-source, patches the game in a way that easily breaks\nForge and other mods, and significantly slows down game launching, often on the order of minutes. Please try Sodium (on Fabric) or Embeddium (on Forge) instead!\nUsing OptiFine with ModernFix is not officially supported, and may cause issues.\n\n## 🖥️ Need a server? Check out BisectHosting!\n\n\n[![Bisect Hosting banner](https://www.bisecthosting.com/partners/custom-banners/6b02ce11-5cf6-4e67-9a75-06474a46308a.webp)](https://bisecthosting.com/embeddedt)",
                    "published": "2023-04-16T20:56:18.092938Z",
                    "updated": "2024-03-22T18:32:33.624691Z",
                    "client_side": "optional",
                    "server_side": "optional",
                    "downloads": 1411743,
                    "followers": 1174,
                    "categories": [
                        "optimization",
                        "utility"
                    ],
                    "additional_categories": [],
                    "game_versions": [
                        "1.16.4",
                        "1.16.5",
                        "1.18.2",
                        "1.19.2",
                        "1.19.4",
                        "1.20",
                        "1.20.1",
                        "23w31a",
                        "23w32a",
                        "23w33a",
                        "1.20.2-pre3",
                        "1.20.2-pre4",
                        "1.20.2-rc1",
                        "1.20.2-rc2",
                        "1.20.2",
                        "23w42a",
                        "23w43a",
                        "23w45a",
                        "1.20.3",
                        "1.20.4",
                        "24w04a",
                        "24w09a"
                    ],
                    "loaders": [
                        "fabric",
                        "forge",
                        "neoforge"
                    ],
                    "versions": [
                        "YmKitGGB",
                        "bakWifEu",
                        "lesun1xH",
                        "TLWpxXmE",
                        "tiJtC3Oq",
                        "RhqFUhKl",
                        "cRc8mTYR",
                        "tF5MXC99",
                        "YxjVHp6F",
                        "JoZVElr5",
                        "4D2n0P0v",
                        "yvUZHRTF",
                        "JC0k0BLU",
                        "aG83F2oq",
                        "wdlIqJM9",
                        "YvfHwxb6",
                        "DkR6UGcX",
                        "ovFOToAu",
                        "j79FcbOV",
                        "fPhurjKv",
                        "WNYg8TPD",
                        "8v4CKHNp",
                        "AR3lYRXy",
                        "V5JUXqmy",
                        "vHjPr4v0",
                        "yMD6AsFA",
                        "JofM3ehE",
                        "jTnRrN6H",
                        "ZD8n3OeB",
                        "XWyZT7uo",
                        "AvZe17Tl",
                        "5cOhMOWI",
                        "kGN22Ber",
                        "t4ArpHYs",
                        "JXUd23wE",
                        "qVu4O77q",
                        "McrIpooS",
                        "42k2MtHD",
                        "Qkwj2yjS",
                        "z5NtPX4A",
                        "Fn6lcgy4",
                        "pgncb4h9",
                        "GhEe98X3",
                        "kFuRlbS1",
                        "I24pbFOk",
                        "HfJUDwN3",
                        "90vs2FzN",
                        "T1YKIVCh",
                        "Qo4bxua4",
                        "HgJiOAQn",
                        "FfgHSOEU",
                        "uMIQRvh7",
                        "lF2pqrO8",
                        "CxL2MT5m",
                        "KuHaMmH1",
                        "SmZNSwfL",
                        "f7G7ygPr",
                        "3LgRU8Ie",
                        "1Mffj87M",
                        "2KYa5aqD",
                        "fqLJ9uB4",
                        "pKlyKViU",
                        "tr7cCUCK",
                        "CTaP4kW5",
                        "P6rbJql2",
                        "JVeaC9TI",
                        "Cs5lOKhd",
                        "p9S1UnOj",
                        "VbB4VqCo",
                        "qbRB2wZ2",
                        "fX8QihJW",
                        "ZopebhEU",
                        "hd1JuF4v",
                        "BTaK8vvw",
                        "euvIjfw2",
                        "WENf7fmL",
                        "RFtlfOIV",
                        "30XnUo00",
                        "e2wI0Dzg",
                        "KvbeSuS1",
                        "D2athySH",
                        "1gWqXFaX",
                        "AMJ0B4Bp",
                        "iO9FlOIm",
                        "G1VHm2Bd",
                        "DHw0yfjn",
                        "eff9HvKh",
                        "9MmJorda",
                        "k4BkxAU7",
                        "NtsxXDeZ",
                        "PKKqdqS8",
                        "DUroUjL7",
                        "CS1MpLrX",
                        "lJnMKe8e",
                        "TsXMK3TX",
                        "uzk1oBWH",
                        "blMuB0D8",
                        "JqdfKm8N",
                        "D1gtdBXw",
                        "WV8pFhUO",
                        "gRSAAIUU",
                        "NQFTTsi6",
                        "y4X4GM0C",
                        "jqteDlfX",
                        "buGrwsKZ",
                        "G5B0BoGA",
                        "oZJClBYn",
                        "QVSzLhRT",
                        "R7Eu2Fxe",
                        "btaNfyRK",
                        "z6cki1Hr",
                        "H7mnYOML",
                        "FDJCtlbz",
                        "e4ytl9KT",
                        "TsDx3td2",
                        "RMzc2zgT",
                        "zf548Phd",
                        "linysjCw",
                        "VaRd7XJ6",
                        "jiSgqiXH",
                        "V1smspgn",
                        "41RDuPe2",
                        "EZjY458j",
                        "cwTG6hyQ",
                        "I7WQ2bG5",
                        "wYFiI0CR",
                        "ad7TwMbL",
                        "1QLOTz4V",
                        "vXwiklcD",
                        "OFdWh7vx",
                        "uBReEWbz",
                        "zaaC7slX",
                        "9RlPyiaK",
                        "nVsxUgHx",
                        "p9vVa5yl",
                        "qlVWBKgU",
                        "v9uT5wj5",
                        "4ZIvpHca",
                        "PT1kduV3",
                        "gBP4wtrN",
                        "gMj6NTPn",
                        "lYUa4fZk",
                        "rJvkWL2n",
                        "c0IRQDNy",
                        "ZAuuntw4",
                        "eUxKumbO",
                        "F7WIWFs8",
                        "uOTQ9aSd",
                        "r1M11yfD",
                        "97pLchRn",
                        "gXrLEidK",
                        "kdOkBzuD",
                        "DybtrvoI",
                        "ZqhmgF0E",
                        "Drr9QiOX",
                        "WJnAag75",
                        "YMq1FhHc",
                        "51N1kQ5P",
                        "at0BBqZ8",
                        "Lbh7ndyf",
                        "T1T1ryiy",
                        "A7VJZ2sj",
                        "GJHB6P6y",
                        "GOlEdlgS",
                        "IMHeD2GV",
                        "XjunZE7n",
                        "6gM4GFBm",
                        "BmneBBYa",
                        "YvOjtot0",
                        "okrRsbRZ",
                        "owXH7FqO",
                        "PV5hrdhD",
                        "1NhyR6t8",
                        "sk9kFgqw",
                        "MqJb4736",
                        "Ixz7TNCN",
                        "cQ0TCwKQ",
                        "pZkNGdFz",
                        "jdCqC43M",
                        "3otSD6Ai",
                        "yviR2zX6",
                        "yRHXqAyS",
                        "xiu6MBJc",
                        "sZJM5bCM",
                        "ZCHErBQZ",
                        "9uRdxCNg",
                        "TE74NXUO",
                        "sBZ9FlQW",
                        "LMfdftzT",
                        "S2KHHn3O",
                        "XZZJ27Mx",
                        "9HGXIyEe",
                        "GANc4eZR",
                        "afRRm0EA",
                        "sWajyf3d",
                        "zDXxoYbt",
                        "5wGMan5g",
                        "ud3vvnM2",
                        "x3K80mPd",
                        "DDGA4vbS",
                        "BKutfSDf",
                        "WqyujHIn",
                        "synysXtc",
                        "xYsH89XA",
                        "5RzoQnZl",
                        "GPUrRuDK",
                        "HfUWwFQ6",
                        "Jw8xBmGc",
                        "NZQwlLgZ",
                        "YufYRxqH",
                        "GaLxviO2",
                        "orPjIEAx",
                        "R0xJ0sx8",
                        "FGNCOJKF",
                        "UxFGc28X",
                        "YDyqtNIH",
                        "ZdOokN06",
                        "gpXn0fGj",
                        "lCU44mLr",
                        "RPmoiZHT",
                        "pWraKWFy",
                        "jHaVrcbU",
                        "F35FyEva",
                        "WYn556RC",
                        "qomlktsB",
                        "Ggtcd6Lc",
                        "D8qeBfgE",
                        "uW4Lb1JW",
                        "RIRMMnjp",
                        "Ve0iT3SL",
                        "PtYPJcwF",
                        "4GPZ0uWs",
                        "PutKck7D",
                        "GLv15259",
                        "wYHO5U66",
                        "fJoMxOnN",
                        "nemKhyeF",
                        "8RyDnURg",
                        "Z9Nf1tw4",
                        "W2wYO1hK",
                        "CzIOJZ7D",
                        "YWxJmxJY",
                        "IDCtf2Pk",
                        "DZ7o2FaT",
                        "Sp3Y3R1p",
                        "YzYQ1W8W",
                        "tI8jU427",
                        "WmXK2piP",
                        "vQEyMOe0",
                        "edDrlUuk",
                        "70e4PROK",
                        "B26rDrrz",
                        "WNErDoy0",
                        "QlqkSEup",
                        "LeHETH9A",
                        "YRcPOXZH",
                        "cQh6zioW",
                        "PJlRMp4v",
                        "LJrDWFEH",
                        "nhQNNUHs",
                        "rigrXobp",
                        "jMVGsL8p",
                        "TJqCeI1u",
                        "xJbpSSiw",
                        "6GPongoq",
                        "ohh21bah",
                        "f1dYaEYt",
                        "TyzpVbn0",
                        "wz12hVLM",
                        "3NFLTjo5",
                        "2Gz3u7pY",
                        "qhD8hz8A",
                        "wS8BEj1H",
                        "lBQ3o7cT",
                        "9ca4pizA",
                        "zNxPnVZT",
                        "oqeQjBRP",
                        "Ypf2M9ta",
                        "XDyibw2U",
                        "RXtwG3lX",
                        "tNwzW4Bd",
                        "88ksqzbj",
                        "TtNOTwgu",
                        "NufUMuUS",
                        "LXlsO4Vo",
                        "5SKZ5Y5s",
                        "zny6etkd",
                        "YS6WlthK",
                        "GaKeTHbJ",
                        "oYMb8L0w",
                        "9R9LPE4L",
                        "16qY2NJU",
                        "SbLn3VXX",
                        "xedGgIRE",
                        "QpVWtj3q",
                        "v9acGUOX",
                        "7wRCZYa1",
                        "tlTrDouz",
                        "v2HWaHmC",
                        "RtHWz3X8",
                        "OxmgvWdr",
                        "ADyFF3WV",
                        "NZfBUD1x",
                        "GREykag1",
                        "iFQICDdq",
                        "SHRLUukI",
                        "6cUAWrqk",
                        "HZze6q1Z",
                        "hhpzMwx0",
                        "ziFdyRZU",
                        "bCqKORCZ",
                        "5YONh7M3",
                        "iMK8fcT3",
                        "qqf2pVIf",
                        "8bcOcx2u",
                        "StT6fUPe",
                        "gDr0pa5m",
                        "mnS5cWZA",
                        "h06WI6hI",
                        "lmCEiM2x",
                        "I019kuJ8",
                        "vQ1eqwUT",
                        "6jU8mhig",
                        "DDQyvO7M",
                        "b1FKKAz8",
                        "p3IGhtdO",
                        "qNrVNwfw",
                        "6caqQhyN",
                        "FDGaMHFj",
                        "jUXzFIgk",
                        "hIcEK3Ks",
                        "FgynMuhC",
                        "9e1ulwtU",
                        "hV2WSfLx",
                        "LZJryrWA",
                        "AW2Wv8MN",
                        "v7RwGjGf",
                        "ge00Oz2v",
                        "LADYq9h9",
                        "19lQhQ2Q",
                        "OMUhFXfR",
                        "r62BNWkZ",
                        "aIrZFfMA",
                        "pTldUfVl",
                        "5vWEqiOB",
                        "jJVhEy8G",
                        "g2qIraQ1",
                        "hymPZqLe",
                        "8cRA5hIs",
                        "1niVYLe4",
                        "WrH5h6hR",
                        "cuMfXHwk",
                        "nYh2qee4",
                        "SEKTVPwa",
                        "2ewMnB7e",
                        "m0WsH8Pp",
                        "5TGI84hb",
                        "QTtrC1Mj",
                        "WzGrDsBM",
                        "G55gynqz",
                        "ZNaGDoHa",
                        "anWzGpyT",
                        "9GyqQvmB",
                        "AIejFbqQ",
                        "IC7LBv4d",
                        "bT6gZuTb",
                        "6wupFeDa",
                        "wdSwq9ke",
                        "P8w71zv8",
                        "IScTO5kT",
                        "vxDb5tOq",
                        "qgFq0dU0",
                        "T3un6Ool",
                        "CDiUztEN",
                        "8hPIV7NS",
                        "7c9U7JHU",
                        "rRcwOsPa",
                        "6IhNexn2",
                        "pAWJdjPp",
                        "7fJivtJU",
                        "XmsWashv",
                        "6YtCmcgN",
                        "MypV6XBd",
                        "gkUP299q",
                        "d6XtsgBG",
                        "DAzGqP8u",
                        "RXaOdpBL",
                        "usNAzp2p",
                        "npSYUF6U",
                        "b5yVw0pL",
                        "giQyDXGo",
                        "nksMSrEt",
                        "oylrfPkW",
                        "UKHyXfho",
                        "2FN93J80",
                        "IJWNOJEe",
                        "gJzUanvd",
                        "Ohe8OvYJ",
                        "1FrMon6Q",
                        "gepXNUac",
                        "6Tz5Moit",
                        "D74K2SYQ",
                        "bBOj6OEk",
                        "oOnGhdHG",
                        "SjO7r0li",
                        "2HMvqcxJ",
                        "A7mqqvc5",
                        "LQU2U5mx",
                        "MAghxxfz",
                        "rf0fSXa5",
                        "s3eeVFK8",
                        "24VdLGlD",
                        "9rqtpYwE",
                        "r9eMwecP",
                        "4BFceRG4",
                        "bsTG5IKj",
                        "fktvkFSD",
                        "uUQmiRzm",
                        "OOAMFEGB",
                        "JeFLzIkV",
                        "IWsQb2tD",
                        "Btq1HFzk",
                        "T8GvLNSz",
                        "oJUG6agJ",
                        "u5R7SNlj",
                        "vHzDHEDN",
                        "YPwzjK2W",
                        "Id3z4wMh",
                        "P0Gj6bhf",
                        "xgdNEjjn",
                        "o6bFEv8x",
                        "f6WrRlmX",
                        "oRGm8e3F",
                        "uazja51B",
                        "JEenvxf5",
                        "XWMKGS0l",
                        "J3SmQdYi",
                        "yx7Ty06C",
                        "b9EwaQ8h",
                        "9eACxgCp",
                        "zlah1a6M",
                        "5LHKYBfs",
                        "jZcXXRiU",
                        "u1FOqNCn",
                        "wMmG6Z2w",
                        "PmGpKiME",
                        "lQs9avbD",
                        "IMUijlCk",
                        "jXMYPayd",
                        "8IOJKzmV"
                    ],
                    "icon_url": "https://cdn.modrinth.com/data/nmDcB62a/e1d2433476995be1b1a94ff1afaf6167752274ae.png"
                },
                "version": {
                    "id": "o6bFEv8x",
                    "project_id": "nmDcB62a",
                    "author_id": "6bGskxLV",
                    "featured": false,
                    "name": "5.14.0+mc1.20.4",
                    "version_number": "5.14.0+mc1.20.4",
                    "changelog": "Depending on the size of this release, there may be a human-readable changelog available on [the wiki page](https://github.com/embeddedt/ModernFix/wiki/Changelog).\n\n## Changes since 5.13.0+1.20.4\n\n  * [Cast to correct event type](https://github.com/embeddedt/ModernFix/commit/761703b4ab6d28a6cba5752c5f11e5700882ba42) - embeddedt\n  * [Remove buffer builder leak fix since you can now close them properly](https://github.com/embeddedt/ModernFix/commit/967d39997f1fc1dfc751b95965da3d28475e522a) - embeddedt\n  * [Bump NeoForge](https://github.com/embeddedt/ModernFix/commit/48b492b9068ceb6b06ff70058e3dc658a88c0e1c) - embeddedt\n  * [Remove Blueprint memory leak patch](https://github.com/embeddedt/ModernFix/commit/e7632b7f0b632fd310683a97c95a65f5db317ea4) - embeddedt\n  * [Reduce load factor of ForgeRegistry delegate map](https://github.com/embeddedt/ModernFix/commit/124112259eabdeb75c66f2c7bed73134c061d786) - embeddedt\n  * [Remove unfinished/obsolete registry & block optimizations](https://github.com/embeddedt/ModernFix/commit/ad1e12a3bbc793c1378c0f1de88b45379de93920) - embeddedt\n  * [Disable primitive chat signing removal if NCR is installed](https://github.com/embeddedt/ModernFix/commit/3e3b9128c34f7d8e478fc8f25da00f9c1fbc84f2) - embeddedt\n  * [Spotless](https://github.com/embeddedt/ModernFix/commit/51c31bf0b840e4da954700d27cec886fe4a10fcd) - embeddedt\n  * [Add oversimplified version of No Chat Reports](https://github.com/embeddedt/ModernFix/commit/feaf363fd89b7802be419aa836221b70317853d8) - embeddedt\n  * [Use fastutil maps for holder lookups in Forge registry](https://github.com/embeddedt/ModernFix/commit/5fe5a484a369c92fdfebed57ee20493257cad725) - embeddedt\n  * [Retrieve missing model when first required](https://github.com/embeddedt/ModernFix/commit/e91220cdea6f276309af84a7e0df86feee3a29a5) - embeddedt\n  * [Fix EntityIDSyncPacket being broken in multiplayer](https://github.com/embeddedt/ModernFix/commit/4dfba0cab4086008903081d312e8c6de1bb0c367) - embeddedt\n  * [Update patch for 1.18](https://github.com/embeddedt/ModernFix/commit/2120774df50bedf35ca412e06caac332eac944c2) - embeddedt\n  * [Fix https://github.com/MinecraftForge/MinecraftForge/issues/9118](https://github.com/embeddedt/ModernFix/commit/12d69bec45312ca790263425e73e2e75408994cb) - embeddedt\n",
                    "changelog_url": null,
                    "date_published": "2024-03-04T17:47:08.248442Z",
                    "downloads": 82621,
                    "version_type": "release",
                    "files": [
                        {
                            "hashes": {
                                "sha512": "d00a879ccbb5f2ed34157baa59845e84fad6e2acbdff2530e9cb80eee5e45279a28debb6f0bde9a7e8c5b85f9f9cf7ef255a08b2e8010f1989b1631afe16c4f9",
                                "sha1": "3e01e37697c90971cf36f25dc281ba0f96ccae18"
                            },
                            "url": "https://cdn.modrinth.com/data/nmDcB62a/versions/o6bFEv8x/modernfix-fabric-5.14.0%2Bmc1.20.4.jar",
                            "filename": "modernfix-fabric-5.14.0+mc1.20.4.jar",
                            "primary": true,
                            "size": 434857,
                            "file_type": null
                        }
                    ],
                    "dependencies": [],
                    "game_versions": [
                        "1.20.4"
                    ],
                    "loaders": [
                        "fabric"
                    ]
                },
                "members": [
                    {
                        "team_id": "xw684WUq",
                        "user": {
                            "id": "6bGskxLV",
                            "username": "embeddedt",
                            "name": null,
                            "avatar_url": "https://avatars.githubusercontent.com/u/42941056?v=4",
                            "bio": "Minecraft performance modder.",
                            "created": "2022-02-28T13:41:58.687703Z",
                            "role": "developer"
                        },
                        "role": "Owner",
                        "ordering": 0
                    }
                ],
                "update_version": {
                    "id": "lQs9avbD",
                    "project_id": "nmDcB62a",
                    "author_id": "6bGskxLV",
                    "featured": false,
                    "name": "5.15.0+mc1.20.4",
                    "version_number": "5.15.0+mc1.20.4",
                    "changelog": "Depending on the size of this release, there may be a human-readable changelog available on [the wiki page](https://github.com/embeddedt/ModernFix/wiki/Changelog).\n\n## Changes since 5.14.0+1.20.4\n\n  * [Mark mixin as client-only](https://github.com/embeddedt/ModernFix/commit/d2680cf29d7fce622c3d9e33605dcb9fad25192a) - embeddedt\n  * [Work around NPEs from early queries to ModelManager](https://github.com/embeddedt/ModernFix/commit/4af1e27a894fe1aca353d248039ab5580aa2866a) - embeddedt\n  * [Deholderize item mesher mixin](https://github.com/embeddedt/ModernFix/commit/add7dd46092d61174a86f9a477c82caee7c73812) - embeddedt\n  * [Update CTM integration for 1.20.4](https://github.com/embeddedt/ModernFix/commit/827550e8af55f42fd69edb90b12243c54ecac5df) - embeddedt\n  * [Update mixin for 1.19 renames](https://github.com/embeddedt/ModernFix/commit/b916ef5ae9b2e49bd0f5556089d6f31fde576e2f) - embeddedt\n  * [Reduce overhead of the PotentialSpawns event](https://github.com/embeddedt/ModernFix/commit/1814bd3e1faff1518119a7b5fcf85784c796023d) - embeddedt\n  * [Add some simple patches to cut down allocation rate when ticking chunks](https://github.com/embeddedt/ModernFix/commit/070b7b6d126af5d04cb6a4315d823a2ad6dbc6bb) - embeddedt\n  * [Update for FML changes](https://github.com/embeddedt/ModernFix/commit/a0fdb3e6d7250168e1c9979132ff7d1f8bc7dd4f) - embeddedt\n  * [Mitigate excessive resource usage from Night Config](https://github.com/embeddedt/ModernFix/commit/bf74ab5a80375db6143660bc64864d912c9c7024) - embeddedt\n  * [Fix \"Illegal prefix\" error in log when custom class/resource locators are in use](https://github.com/embeddedt/ModernFix/commit/e1ff64785ed747d33af3067c985cebe82cf7a0c8) - embeddedt\n  * [Do not treat invalid ModelResourceLocations as top-level when baking dynamic models](https://github.com/embeddedt/ModernFix/commit/0e9d024c5d4764aba604f5baeffe785193043ef9) - embeddedt\n  * [Loom 1.5](https://github.com/embeddedt/ModernFix/commit/5e20e25c4d355c9fff7c0f2a7000585d1d029efa) - embeddedt\n  * [Update for Forge registry changes](https://github.com/embeddedt/ModernFix/commit/e39cc1ca15e4f9b19bbe2e9d5931a1dbef928505) - embeddedt\n  * [Retrieve block name once per state](https://github.com/embeddedt/ModernFix/commit/31cc0a0da0db9e9539047d1b593c6d8deb15a12b) - embeddedt\n  * [Speed up ModelBakeEventHelper constructor](https://github.com/embeddedt/ModernFix/commit/06726296fe46bdd86e8c6e498ef82ad37d523d8f) - embeddedt\n  * [Fix registry progress bar going off end of screen in NeoForge](https://github.com/embeddedt/ModernFix/commit/e22f5caec7ebee1796374ad737cda45e71bdfac7) - embeddedt\n  * [Move stalled async chunk load detection to its own config](https://github.com/embeddedt/ModernFix/commit/d854fcffffa6788a53d3ba336854d4532c4a5882) - embeddedt\n  * [Disable the testmod by default](https://github.com/embeddedt/ModernFix/commit/e6bb67cb05ecbfd96a21a7fdc3e9e67e2f7c6e81) - embeddedt\n  * [Store delegates on registry objects to avoid map lookup](https://github.com/embeddedt/ModernFix/commit/36f2564d6adda3c1cb1811d9075c5e2a475e8afd) - embeddedt\n  * [Disable pose stack bugfix when OptiFine is installed](https://github.com/embeddedt/ModernFix/commit/40b9ac6002467f737a87b201fcf662005525b45f) - embeddedt\n  * [Make the block model cache thread-local instead of using a lock](https://github.com/embeddedt/ModernFix/commit/a45783647fc199d4b08c9cc6575cce314790ad6a) - embeddedt\n",
                    "changelog_url": null,
                    "date_published": "2024-03-22T18:30:14.417592Z",
                    "downloads": 2125,
                    "version_type": "release",
                    "files": [
                        {
                            "hashes": {
                                "sha512": "fa163194316f7129d275064bc4ac4e29395673f046c45625f7ce5933318d411c08a2538675a61a19db147324ba76fec44fe6dbd7279be34c62b3f7adeceb072c",
                                "sha1": "dbbb4d797bb89ac02eb6fd7fb310872ef37c23d1"
                            },
                            "url": "https://cdn.modrinth.com/data/nmDcB62a/versions/lQs9avbD/modernfix-fabric-5.15.0%2Bmc1.20.4.jar",
                            "filename": "modernfix-fabric-5.15.0+mc1.20.4.jar",
                            "primary": true,
                            "size": 440683,
                            "file_type": null
                        }
                    ],
                    "dependencies": [],
                    "game_versions": [
                        "1.20.4"
                    ],
                    "loaders": [
                        "fabric"
                    ]
                },
                "incompatible": true
            },
            "file_name": "modernfix-fabric-5.14.0+mc1.20.4.jar"
        },

After udpating

        "mods\\modernfix-fabric-5.15.0+mc1.20.4.jar": {
            "sha512": "dbbb4d797bb89ac02eb6fd7fb310872ef37c23d1",
            "disabled": false,
            "metadata": {
                "type": "unknown"
            },

Manually putting back the old metadata solve this issue. Duplicating the instance also solves this issue. It seems that it recalculate all the metadata and put back those how were missing.

Also, I've observed that some mod

vannomad commented 2 weeks ago

Can confirm Duplicating the instance is a valid workaround, i was about to completely recreate my modpack but this helps for now.