modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
859 stars 146 forks source link

Login into modrinth account through Theseus v0.71 fails #1147

Closed JosueGalRe closed 2 weeks ago

JosueGalRe commented 4 months ago

Describe the bug

When trying to login into the launcher using my Modrinth account, I try to copy and paste my password (I use a password manager). When I try to click the login button it fails and shows the error message attached below.

Steps to reproduce

  1. Go to configuration
  2. Click on Sign In
  3. Enter your username
  4. Copy and paste your password
  5. Click on login

Expected behavior

I should be prompt to the next screen, and be asked for the 2FA value

System information

Processor AMD Ryzen 9 5950X 16-Core Processor 3.40 GHz Installed RAM 64.0 GB System type 64-bit operating system, x64-based processor Edition Windows 11 Pro Version 23H2 OS build 22631.3447 Experience Windows Feature Experience Pack 1000.22688.1000.0 Card name NVIDIA GeForce RTX 3080 Manufacturer NVIDIA App version Theseus v0.71

Additional context

image

AlyxPink commented 4 months ago

I'm not sure if it's related, but just before getting this message, I was having an error message about the captcha and same thing: the captcha form never showed up.

JosueGalRe commented 4 months ago

I'm not sure if it's related, but just before getting this message, I was having an error message about the captcha and same thing: the captcha form never showed up.

I had the same issue too

brawaru commented 4 months ago

Modrinth is using Turnstile CAPTCHA by Cloudflare that automatically completes in background. We've recently added completion indication to the site, but we are yet to add it to Modrinth App. But if you see this message, all you need to do is to wait a bit (usually 10 seconds is plenty for it to complete). IIRC the CAPTCHA resets every time you press the button, so spamming it doesn't help.

Also, this error is not specific to 0.7.1. This been a major pain point for several versions already.

brawaru commented 4 months ago

CC @Prospector you implemented the indication on the site, do you think you can port this change to the app as well?

TankHero0815 commented 3 months ago

Any news here? Having this issue since downloading the app in April. Every time I get this error:

image

brawaru commented 3 months ago

No news, you'd see the updates on the issue if there were any. Just skip singing in to your Modrinth account altogether, it doesn't do anything anyway. It seems that the CAPTCHA is completely borked, and it doesn't have anything to do with the waiting.

Cragsand commented 3 months ago

Also having this issue. Logging in via a browser works fine but through the launcher is broken. I'm pretty sure a captcha is supposed to be shown but the UI for it doesn't show for some reason.

image "An error occurred invalid args challenge for command login_pass: command login_pass missing required key challenge"

rockdemon696 commented 3 months ago

The "invalid args 'challenge' for command 'login_pass' : command login_pass missing required key challenge seem related to 2FA. I got the other message about "captcha" first, checked I could log in to the site, while there noticed I could enable 2FA, enabled 2FA, then went back to the app and got the message about "login_pass".

John-Development commented 2 months ago

Modrinth is using Turnstile CAPTCHA by Cloudflare that automatically completes in background. We've recently added completion indication to the site, but we are yet to add it to Modrinth App. But if you see this message, all you need to do is to wait a bit (usually 10 seconds is plenty for it to complete)

Currently in the web cloudflare is requesting (at least for me during all the day) user input when I try to login. This tab opens every time I try to login into modrinth, so I am guessing that waiting in the app for cloudflare to finish the verification is not a valid option anymore.

imagen

brawaru commented 2 months ago

That's because you use a privacy pass extension, which shows its own CAPTCHA with interactive challenge in order to get a pass. Without it, it should complete without interactive challenge.

John-Development commented 2 months ago

Oh I didnt know that, thank you! Now it logins without asking for interacion in the web :D

pedroffabrin commented 2 months ago

Man, I'm having the same problem, on the same version, what's happening?

Franco227 commented 2 months ago

Same captcha issue on Fedora 40 (using the AppImage file)

markaabo commented 1 month ago

This is still an issue in august

Tyto-ooo commented 2 weeks ago

the issue seems to be fixed in v0.8.2

John-Development commented 2 weeks ago

Can confirm