modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
862 stars 146 forks source link

Show Fabric mods when adding mods on a quilt instance. #1188

Open Unionegation opened 3 months ago

Unionegation commented 3 months ago

Is your suggested enhancement related to a problem? Please describe.

Whenever you want to add a fabric mod to quilt, even though they are perfectly compatible, Modrinth does not show fabric mods when adding to a quilt instance.

Describe the solution you'd like

When adding content to a quilt instance, show fabric mods and allow them to be downloaded. However, given not all fabric mods are compatible with quilt, maybe flash a warning saying 'this might not work'. If you do that, please also add a toggle to turn it off.

Describe alternatives you've considered

You can also automatically mark fabric mods for quilt, as right now most of them are compatible. Do the warning if you are to do this.

Additional context

No response

ascenstohe4vn commented 3 months ago

same thing with 1.20.1 forge mods working on neoforge, but not being shown as compatible

Prospector commented 3 months ago

This is up to the project creators to mark appropriate versions compatible. Not all mods are perfectly compatible, so this isn't something we want to force upon all mods.

Andr994k commented 1 month ago

This is up to the project creators to mark appropriate versions compatible. Not all mods are perfectly compatible, so this isn't something we want to force upon all mods.

It isn't feasible for all mod creators to correctly mark their mods, could an option maybe be made for this? That way it isn't forced upon anyone, but can be fixed for those who want it.

blryface commented 1 month ago

It is up to the creators, and they may have not tagged it as compatible with quilt due to it really not being It's honestly way less of an issue because quilt is basically dead. And making that feature on by default could cause people to complain that "modrinth corrupted my world!" if something gets broken really badly

Thinkseal commented 1 month ago

from my experience the game just will not boot when a mod on fabric does not work on quilt