modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
904 stars 165 forks source link

Modpack won't launch after killing it #1302

Open SaTae66 opened 2 months ago

SaTae66 commented 2 months ago

Please confirm the following.

What version of the Modrinth App are you using?

Theseus v0.7.1

What operating systems are you seeing the problem on?

Linux

Describe the bug

I created my own personal modpack with lots of mods and was fooling around with the garbage collection config, f'ed up and had to kill Mincecraft with a SIGKILL. Already did that like 20 times before without issues, but it looks like I now corrupted something. I can still run any other modpack, but the one a killed fails to start with:

2024-07-17T19:52:28.827641445+02:00 ERROR theseus_gui::error: error=Error launching Minecraft: Cached process 14912 has no accessable path span_trace=   0: theseus::state::children::insert_new_process
           with profile_relative_path=ProfilePathId("Vanilla Ultimate Unstable")
             at theseus/src/state/children.rs:263
   1: theseus::launcher::launch_minecraft
             at theseus/src/launcher/mod.rs:371
   2: theseus::api::profile::run_credentials
           with path=ProfilePathId("Vanilla Ultimate Unstable")
             at theseus/src/api/profile/mod.rs:763
   3: theseus::api::profile::run
           with path=ProfilePathId("Vanilla Ultimate Unstable")
             at theseus/src/api/profile/mod.rs:742

Seeing cached in the log, I just deleted ~/.cache/modrinth-app but that didn't help. I have no clue about Rust whatsoever, so I couldn't really deep-dive in the mentioned code.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

blryface commented 2 months ago

not a bug

blryface commented 2 months ago

actually maybe it is but why did you kill it in that weird way

SaTae66 commented 2 months ago

Actually my bad, I figured it out. When copying my JVM settings from one profile to the other, I introduced an error, so instead of sth like -XX:InitialHeapSize=8g I had -XX:InitialHeapSize8g (missing =) which wouldn't let the JVM start at all. So not really a corruption/caching whatever issue, but rather an unclear error message. Not sure if this is even fixable.