search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
861 stars 149 forks source link

Unnecessary tag for 'See All' versions button on project page #1437

Closed w26ad closed 5 months ago

w26ad commented 8 months ago

Describe the bug

Unnecessary tag #all-versions in link for 'See All' versions button on project page It literally does nothing, button opens the same list of versions separated into pages as Versions button msedge_GaM9ukOalX

Steps to reproduce

  1. Go to any project with lots of versions like Fabric API: https://modrinth.com/mod/fabric-api
  2. Click to Versions button
  3. You'll see list of versions separated into pages
  4. Return to Description page
  5. Hover your mouse over 'See all' button in sidebar
  6. You'll see the link in left corner with #all-versions tag.
  7. Click on this button
  8. You'll see the same list of versions separated into pages as in Step 3
  9. So this tag does nothing and is unnecessary

Expected behavior

No unnecessary tag for 'See All' versions button on project page

Additional context

Maybe link with this tag should show all versions on one page?

brawaru commented 7 months ago

This is not correct. This fragment is necessary to automatically scroll the page to the versions list upon switching the tab. It was also supposed to shift focus there for accessibility reasons, but this doesn't work for whatever reason (which is a bug).