modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Inconsistent page navigation from 5th page of search results #1572

Closed obnyis closed 2 months ago

obnyis commented 1 year ago

Is your suggested enhancement related to a problem? Please describe.

When navigating through multiple pages of search results, to go from the 5th page to the 6th you need to use the next page arrow.

This should switch to the 1 - 4 5 6 - X form to allow continued navigation by selection of a page number.

Describe the solution you'd like

Line 96 in ui/Pagination.vue should be updated to else if (this.page > 4) {

https://github.com/modrinth/knossos/blob/05d994889d8567240148047e5a0384c1819615ee/components/ui/Pagination.vue#L96C36-L96C36

Describe alternatives you've considered

No response

Additional context

When on the 5th page: image

After navigating to the 6th page: image

When on the 4th from last page: image

After navigating to the 5th from last page: image

triphora commented 1 year ago

This was changed in modrinth/knossos#1181 - @Prospector something for you

Minenash commented 2 months ago

Fixed at some point