modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
946 stars 178 forks source link

Browsing currently not working at all #1594

Closed samualtnorman closed 1 year ago

samualtnorman commented 1 year ago

Describe the bug

browsing currently, does not work this goes for loading the page with a q query parameter and doing search after the page has loaded (which emits an error in the console)

Steps to reproduce

Visit https://modrinth.com/mods or https://modrinth.com/plugins or https://modrinth.com/datapacks or https://modrinth.com/shaders or https://modrinth.com/resourcepacks https://modrinth.com/modpacks

and you'll see an empty list

Expected behavior

there should be a list of whatever you're browsing

Additional context

here's the error emitted in the console for firefox and chrome

in firefox when typing something into search and pressing enter:

XHRGET
https://api.modrinth.com/v2/search?limit=20&index=relevance&query=foo&facets=[["categories:'forge'","categories:'fabric'","categories:'quilt'","categories:'liteloader'","categories:'modloader'","categories:'rift'"],["project_type:mod"]]
[HTTP/2 400 Bad Request 426ms]

GET
    https://api.modrinth.com/v2/search?limit=20&index=relevance&query=foo&facets=[["categories:'forge'","categories:'fabric'","categories:'quilt'","categories:'liteloader'","categories:'modloader'","categories:'rift'"],["project_type:mod"]]
Status
400
Bad Request
VersionHTTP/2
Transferred689 B (191 B size)
Referrer Policystrict-origin-when-cross-origin
Request PriorityHighest

    access-control-allow-origin
        *
    cf-cache-status
        DYNAMIC
    cf-ray
        7d177f9e3eef76f0-LHR
    content-type
        application/json
    date
        Sat, 03 Jun 2023 11:12:00 GMT
    server
        cloudflare
    strict-transport-security
        max-age=15552000; includeSubDomains; preload
    vary
        accept-encoding, Origin, Access-Control-Request-Method, Access-Control-Request-Headers
    x-content-type-options
        nosniff
    X-Firefox-Spdy
        h2
    x-ratelimit-limit
        300
    x-ratelimit-remaining
        291
    x-ratelimit-reset
        23

    Accept
        */*
    Accept-Encoding
        gzip, deflate, br
    Accept-Language
        en-GB,en;q=0.7,en-US;q=0.3
    Connection
        keep-alive
    DNT
        1
    Host
        api.modrinth.com
    Origin
        https://modrinth.com
    Referer
        https://modrinth.com/
    Sec-Fetch-Dest
        empty
    Sec-Fetch-Mode
        cors
    Sec-Fetch-Site
        same-site
    TE
        trailers
    User-Agent
        Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/113.0

in chrome typing something into search and pressing enter:

entry.86768076.js:1     GET https://api.modrinth.com/v2/search?limit=20&index=relevance&query=foo&facets=[[%22categories:%27forge%27%22,%22categories:%27fabric%27%22,%22categories:%27quilt%27%22,%22categories:%27liteloader%27%22,%22categories:%27modloader%27%22,%22categories:%27rift%27%22],[%22project_type:mod%22]] 400
o @ entry.86768076.js:1
s @ entry.86768076.js:1
(anonymous) @ _searchProjectType_.56dc6e3f.js:3
Promise.then.i @ asyncData.322b27d7.js:1
r.refresh.r.execute @ asyncData.322b27d7.js:1
T @ _searchProjectType_.56dc6e3f.js:3
i.onInput.s.<computed>.s.<computed> @ _searchProjectType_.56dc6e3f.js:3
sn @ entry.86768076.js:1
it @ entry.86768076.js:1
n @ entry.86768076.js:1
samualtnorman commented 1 year ago

seems to now be fixed