search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
1k stars 187 forks source link

Minecraft version range with a dash/hyphen is incorrectly parsed #1713

Open Madis0 opened 1 year ago

Madis0 commented 1 year ago

Describe the bug

My mod manifest indicates that it supports minecraft": ">=1.19.3-", meaning 1.19.3 and any later releases/snapshots/pre-releases/rc-s. Knossos, however, thinks that it is 1.19-1.19.3.

Affects Fabric, may affect Quilt, probably doesn't affect Forge mods.

Steps to reproduce

  1. Set mod's supported MC version to minecraft": ">=1.19.3-" in the manifest
  2. Try uploading it to Modrinth
  3. Notice what supported versions it suggests.

Expected behavior

Expected the mod to have 1.19.3 and any later releases/snapshots marked (when they exist).

Additional context

Confirmed by Emma: https://discord.com/channels/734077874708938864/783153806531100673/1063562112502341703

See also: https://semver.org/#spec-item-9

Minenash commented 1 year ago

I don't think the - is causing the bug. During my 1.19.3 update round, >=1.19.3 gets turned into 1.19-1.19.3