search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Scrolling position is lost when the hamburger menu is opened and closed #1737

Closed douira closed 1 year ago

douira commented 1 year ago

Describe the bug

On mobile, when the hamburger menu on the main page is opened and then closed via the X button, the scrolling position on the page is lost. As a user I assume that interacting with an unrelated menu doesn't cause the page to loose my scrolling position.

Steps to reproduce

  1. Go to https://modrinth.com/ in mobile mode
  2. Scroll down somewhat
  3. Open the hamburger menu
  4. Close the hamburger menu with the X
  5. Observe that the scrolling position is once again at the top

Expected behavior

After closing the hamburger menu, the scrolling position should be the same as before opening it.

Additional context

Screen recording of this: https://user-images.githubusercontent.com/17120022/211178333-30d6574a-0673-461a-b255-585fe8b566ba.mov

I can reproduce this identically with Safari on my iPhone

triphora commented 1 year ago

No longer relevant since modrinth/knossos#933.