modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Project page overflows when viewport width is just above 1280px #1743

Closed misode closed 1 year ago

misode commented 1 year ago

Describe the bug

modrinth/knossos#777 introduced a visual bug that appears when the viewport width is a bit larger than 80 rem (or 1280 px). This does not affect production.

Responsible style changes: https://github.com/modrinth/knossos/blame/6f58e9e7bb36a5a781ba1685e8c77ea1e15eb93f/assets/styles/layout.scss#L98-L100

image

https://user-images.githubusercontent.com/17352009/209940736-34d4ca12-5052-417a-bf83-6cfc2c98c172.mp4

Steps to reproduce

  1. Go to https://knossos-git-redo-version-page-modrinth.vercel.app/resourcepack/9TXDJska
  2. Adjust your viewport width so it is a bit larger than 1280 px
  3. Notice that the header touches both left and right edge of the viewport, but the main content has padding on the left and overflows a bit on the right.

Expected behavior

Content should not overflow on the right side. The header and main content left and right edges should align.

Additional context

No response

misode commented 1 year ago

This has become substantially worse

image

image

Geometrically commented 1 year ago

What's the screen width and browser?

Geometrically commented 1 year ago

found the issue, will be resolved by my latest PR

misode commented 1 year ago

Anything between 1025px and ~1325px has a bit of the description overflowing. Chrome 110

misode commented 1 year ago

found the issue, will be resolved by my latest PR

Can confirm it's partially fixed by that PR. It's back to how I described in the initial comment of this issue.