Filtering versions/changelogs by version doesn't work anymore

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!

https://modrinth.com

Other

1.01k stars 189 forks source link

Filtering versions/changelogs by version doesn't work anymore #1863

Closed Madis0 closed 2 years ago

Madis0 commented 2 years ago

Environment

No response

Describe the bug

On the website, the Minecraft version filters do not work unless you select exactly one loader

Steps To Reproduce

Go to a mod's page
Click versions
Select some versions under "Filter versions"
Wait for results

Expected behavior

Expected results but they won't come until a loader is selected. This is bad because e.g. I don't care if a mod developer marked their individual version as Fabric or Quilt. Or maybe I want to see if those 1.14 versions are for Fabric or Forge...

Additional context

Related: modrinth/code#1901

Siphalor commented 2 years ago

Well, this has been marked as a duplicate to my issue, so I'm gonna comment here :)

The loader filter is not even there anymore, so there is currently no way to filter at all.
This issue has a terrible name / description. It doesn't even mention the name of the subject "Changelogs". It is basically unsearchable.

But I'm happy to see that there's already a pull request attached :+1:

Edit: Ok, I have to apologize for the small rant: Apparently this also happens on the Version page, so this issue does indeed make sense (Although the title could still be more concise :smile: )

Madis0 commented 2 years ago

@Siphalor by all means, suggest the title or description so I can edit it :D I just named it after what I found the bug to be.

Siphalor commented 2 years ago

I'd suggest something like "Filtering versions/changelogs by version doesn't work anymore". That probably also reflects the changed situation better (no more modloader selection).