search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

PolyMC still missing from modpack pages. #1880

Closed ubionexd closed 2 years ago

ubionexd commented 2 years ago

Environment

Website

Describe the bug

Some small inconsistency.

PolyMC recently added support for Modrinth packs and a link for PolyMC has been added to the red banner in the Modpacks page, that they support Modrinth packs now. But if you go to any actual modpack's page (like Fabulously Optimized) you can see, that the red banner there has no link or mention to PolyMC supporting packs.

image

Steps To Reproduce

  1. Go to the Modpacks page
  2. Click on any modpack (eg. Fabulously Optimized)
  3. Look at the red "Disclaimer" banner on the top.

Expected behavior

There should be a link for PolyMC or it should mention, that PolyMC does support Modrinth packs.

Additional context

I can make a PR fixing this. It will be done by tomorrow.

DioEgizio commented 2 years ago

I might didn't remember to have updated this in modrinth/knossos#497 :P

ubionexd commented 2 years ago

Nevermind, at least i had something to do today :)

ubionexd commented 2 years ago

Issue fixed and resolved in modrinth/knossos#499