search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Filtering loaders and game versions together does not specifically look for them on the same version #1907

Closed mist475 closed 9 months ago

mist475 commented 2 years ago

Environment

Website

Describe the bug

If you select a specific mod loader and version (for example "forge" & "1.7.10") you get all mods that have a forge version and a 1.7.10 version. This includes mods whose 1.7.10 version isn't on forge.

For Example: image

Of the mods listed here the odd one out is Alternate Current, which has a 1.7.10 Legacy Fabric version but not a forge version (the only forge version of the mod listed is for 1.18)

Steps To Reproduce

1 Go to https://modrinth.com/mods 2 Select "Forge" in Loaders 3 Select "1.7.10" in versions 4 Click on "Alternate Current" 5 Click on "Versions" 6 Select "Forge" as Loader 7 Only 1.18 is shown

Expected behavior

Only mods whose 1.7.10 version uses Forge should show up

Additional context

No response

MagnusHJensen commented 1 year ago

I can't reproduce this error. Seems to sort fine now.

Prospector commented 1 year ago

It's still a problem, but it's a labrinth problem, not a knossos problem.

See: https://modrinth.com/mods?q=not%20enough%20wands&g=categories%3A%27fabric%27&v=1.19.3

Not Enough Wands has a fabric version and a 1.19.3 version, but not a fabric and 1.19.3 version, which is what the user is trying to look for.

Andre601 commented 1 year ago

Not Enough Wands has a fabric version and a 1.19.3 version, but not a fabric and 1.19.3 version, which is what the user is trying to look for.

I think you made a typo here? (Actually no, just a bit hard to understand for me)

MagnusHJensen commented 1 year ago

Odd. The example mentioned by OP is not a problem anymore.

Is the the issue in labrinth? https://github.com/modrinth/labrinth/issues/483

Prospector commented 1 year ago

The example mentioned by OP is not a problem anymore.

well it seems the mod doesn't exist anymore so that would be why

Edit: and yeah, that's the labrinth issue.

Edit 2: ehh seems like a different thing actually.

MagnusHJensen commented 1 year ago

Right here: https://modrinth.com/mod/alternate-current

Prospector commented 1 year ago

ah, I see the 1.7.10 version just doesn't exist anymore.

triphora commented 9 months ago

Fixed as of modrinth/labrinth#731