modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
862 stars 150 forks source link

Plugins that distribute dedicated server mods show "Install in Modrinth App" in Download wizard #2200

Open WiIIiam278 opened 3 weeks ago

WiIIiam278 commented 3 weeks ago

Please confirm the following.

What browsers are you seeing the problem on?

Chrome (including Arc, Brave, Opera, Vivaldi)

Describe the bug

Plugins that distribute dedicated server-only mods display the "Install in Modrinth App" button in the Download wizard.

image

Steps to reproduce

  1. Go to the page of a plugin that also distributes a server-side Fabric mod: e.g. https://modrinth.com/plugin/huskhomes
  2. Click Download
  3. Observe that a "Install with Modrinth App" button appears.

Dedicated server-only mods (those which do not provide a client entrypoint) will not initialize when loaded by the client folder, causing confusion. This is already a difficult enough thing to communicate to the layman as-is, so it's pretty important to me that this messaging is clear in the most important place of all (the "Download" button)

Expected behavior

This button should not be present (as is the case with plugins that are Spigot-only): https://modrinth.com/plugin/coreprotect

Additional context

No response

Minenash commented 2 weeks ago

I know environments are getting an update soon, and part of that will be the ability to indicate dedicated server only. Hopefully as a part of that, the button won't show if all versions are just dedicated only