modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
972 stars 181 forks source link

New ads rendering over content in some pages #2257

Open LorenzoBiassio opened 2 months ago

LorenzoBiassio commented 2 months ago

Please confirm the following.

What browsers are you seeing the problem on?

Chrome (including Arc, Brave, Opera, Vivaldi)

Describe the bug

I'm using the latest chrome version, no ad blocker, no other extensions, and the ads appear to be rendering bigger then they should, sometimes the go under the content which is kinda ugly but is fine, but sometimes they go over and are really distracting. I've tried to change some cosmetics in the page (the color mode and the panels side), but it changed nothing.

Over the content Screenshot 2024-08-22 153255 Under the content Screenshot 2024-08-22 153443

when using firefox the ads appear normal Screenshot 2024-08-22 155039

Steps to reproduce

  1. Open modrinth.com in chrome
  2. Navigate to a page that has ads
  3. The ads are too big

Expected behavior

The ads should be the same size in chrome as they are in firefox

Additional context

No response

null2264 commented 2 months ago

Also happened to me on Floorp (based on Firefox ESR 128). The root cause seems to be the site didn't respect browser font size setting properly, I set my browser font size to 13 instead of the default 16.

size 13: image

size 16: image

imheavi commented 2 months ago

Some ads also extend downward, covering filters. This screenshot is on Edge. image

snewell92 commented 1 month ago

I'm on a 1080p screen on windows and also see this.

See other issues as well:

Image