modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
870 stars 153 forks source link

Downloading required resource packs for data packs is overly complicated #2277

Open MonkosumDev opened 3 weeks ago

MonkosumDev commented 3 weeks ago

Please confirm the following.

What parts of Modrinth is your feature request related too?

Website

Is your suggested feature related to a problem? Please describe.

I've made a data pack that heavily relies on its resource pack for sprites, models, text ect., but the latest UI update made downloading the resource pack more complicated than it used to be. Originally, I added both the data pack and resource pack to the featured versions, which worked really well for the most part, but as featured versions don't exist anymore, this approach is now off the table. From what I've seen, you instead need to go to the version list and either download a standalone release of the resource pack, or go to the latest version of the data pack, scroll all the way to the bottom, and then download the resource pack. Considering that the resource pack is pretty much essential (even marked as "required" on the data pack page), this 100% needs change.

Describe the solution you'd like

I understand that the featured versions caused some problems in the past, with overly long lists that just confused users more than anything else, so while I would love for them to return, I don't expect this decision to get reverted. Instead, I have 2 other ideas to solve this problem.

  1. Make it so that if you download a data pack through the new download interface, the resource pack gets downloaded alongside it (should be automatic, maybe just add a prompt here for optional resource packs). I believe this would be the cleanest solution, even better than my old method with the featured versions list.

  2. Add "Resource Pack" as an option for the platform. The main reason people won't find the resource pack is because the new download interface only shows the data pack. In the past, I marked the standalone resource pack releases as data packs, since resource packs couldn't be selected as a platform. Adding this would at least allow people to access the resource pack through the new interface. It's not nearly as clean as the first method, but honestly something I would like to see regardless of this whole issue. This seems like the simple way out, something that works well enough and shouldn't be too hard to implement (note that I don't know anything about the modrinth API, this is just an assumption)

Describe alternatives you've considered

No response

Additional context

Prospector commented 3 weeks ago

I see, what you were doing before has never been supported and is not allowed. However, this does raise a good point that the new download UI does not show dependencies which was a major oversight. I'll fix this.

As for your project, you need to either add the resource pack as a separate project that the data pack can depend on, or as uploaded "additional files" and select them as a required resource pack, so that Modrinth can properly understand that the resource pack is required. As it stands right now, you are uploading a resource pack as a data pack which will break things.