modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
959 stars 178 forks source link

redesign: only able to exclude loaders #2279

Open llakala opened 2 months ago

llakala commented 2 months ago

Please confirm the following.

What browsers are you seeing the problem on?

Chrome (including Arc, Brave, Opera, Vivaldi), Firefox

Describe the bug

When selecting loaders, the ability to "exclude" a version in the search selection is provided. This is a super useful concept, but it's purely limited to loaders.

Steps to reproduce

  1. Visit this page: https://modrinth.com/mods
  2. Click the Filters button
  3. Select a loader option, observe the crossed-out circle icon that lets you ignore an option
  4. Select an option in a different category, observe that the icon doesn't appear

Expected behavior

The ability to ignore any option would be provided. This would be specifically useful for searching mods that are specifically serverside, since selecting "Server" includes mods that are needed on both the client and server.

Additional context

No response

Prospector commented 2 months ago

Selecting "Server" does not show mods that are needed on both client and server, it only shows mods that work when just on a server, so I am a little confused at this issue.

llakala commented 2 months ago

Selecting "Server" does not show mods that are needed on both client and server, it only shows mods that work when just on a server, so I am a little confused at this issue.

Well, kind of. You're right, it doesn't show client AND server mods, that was a typo on my part. But it does still show client OR server mods, which can't be filtered out. Regardless, filtering for exclusively serverside was just an example of something that would only be possible if the exclusion feature was usable on the other filters.