Export ignores folders in config folder

killbot24 commented 3 weeks ago

Please confirm the following.

[X] I checked the existing issues for duplicate problems
[X] I have tried resolving the issue using the support portal
[X] I have ensured my Modrinth App installation is up to date

What version of the Modrinth App are you using?

0.8.2

What operating systems are you seeing the problem on?

Windows

Describe the bug

When exporting a modpack and haveing config selected It ignores/ excludes folders in the file

Given a lot of mods have folders with multi configs kinda breaks it

Steps to reproduce

Get a modpack/create one that has folders in config eg one with a fancy menu
click export on a modpack
look in config no folders present even if in the modpack folder there is folder in the config folder
Export.

Expected behaviour

When exporting a mod pack it should export everything in the config folder

Additional context

No response

MiguVT commented 3 weeks ago

Same issue, i will edit the zip and move the overrides manually, i dont find other fix at the moment

DevLung commented 3 weeks ago

Same issue, doesn't just apply to config/, any folder that is not directly in the instance root isn't included, regardless of it having any contents... (issue probably exists since 0.8.1, I have saved previous versions of my pack where it worked just fine)

Norbiros commented 3 weeks ago

Duplicate of #2271. It was fixed in #2273

MiguVT commented 3 weeks ago

when will it be released in prod?

DevLung commented 2 weeks ago

when will it be released in prod?

it's released now (0.8.5)

MiguVT commented 2 weeks ago

Please confirm the following.
* [x]  I checked the [existing issues](https://github.com/modrinth/code/issues) for duplicate problems

* [x]  I have tried resolving the issue using the [support portal](https://support.modrinth.com)

* [x]  I have ensured my Modrinth App installation is up to date
What version of the Modrinth App are you using?

0.8.2

What operating systems are you seeing the problem on?

Windows

Describe the bug

When exporting a modpack and haveing config selected It ignores/ excludes folders in the file

Given a lot of mods have folders with multi configs kinda breaks it

Steps to reproduce
1. Get a modpack/create one that has folders in config eg one with a fancy menu

2. click export on a modpack

3. look in config no folders present even if in the modpack folder there is folder in the config folder

4. Export.
Expected behaviour

When exporting a mod pack it should export everything in the config folder

Additional context

No response

You can close the issue, fix released <3

killbot24 commented 2 weeks ago

Still occours on 0.8.5

MiguVT commented 2 weeks ago

Still occours on 0.8.5

Dont happens, try purge cache: imagen

Felix14-v2 commented 2 weeks ago

If the cache is can be broken, then the issue is still relevant

MiguVT commented 2 weeks ago

If the cache is can be broken, then the issue is still relevant

No, it should be other issue, its a known issue that cache bugs some things like modpack updates, some functions when edited, etc.

modrinth / code