modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
984 stars 185 forks source link

Modrinth App 0.8.7 installer requires elevation #2386

Open brawaru opened 2 months ago

brawaru commented 2 months ago

Please confirm the following.

What version of the Modrinth App are you using?

0.8.7

What operating systems are you seeing the problem on?

Windows

Describe the bug

In 0.8.7 installer has started to request elevation and will not work without running as Administrator.

Users who installed 0.8.5 on their non-Administrator accounts will not be able to update to 0.8.7, as the app immediately launches the installer without UAC prompt, resulting in the following error message:

“Error opening file for writing: C:\Program Files\Modrinth App\Modrinth App.exe. Click Abort to stop the installation, Retry to try again, or Ignore to skip this file.”

Steps to reproduce

  1. Download 0.8.7 installer from website.
  2. Run it.

Expected behavior

The installer will run as on user level just like 0.8.5 did, without requiring elevation. There is ZERO reason for Modrinth App to be installed for all users.

Additional context

0.8.5 not requiring elevation was great news for users who don't have administrator access, which meant Modrinth App became accessible to them. It's also good news for users who have multiple accounts on the system where other users don't need Modrinth App, thus reducing pollution.

Relevant change: https://github.com/modrinth/code/commit/0b31f2eb41eeee919053b06f878c0e941a36787d#diff-00b0fca951a755d54b05189f647b30e32c5c0532be672dc4d594b3de7e42783dR27-R30

wolvyreen commented 2 months ago

Also seeing this. My childs user profile is a non-admin account. This doesnt seem to happen for admin accounts.

oliverjhn commented 2 months ago

Any progress on this?

hablethedev commented 1 month ago

Aaaaand this happened on a new update - why can't it be like VSCode and have a user installation OR even better, actually request admin permissions!

Edit: Only way to update is to reinstall with the installer as admin...

Image