modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
994 stars 186 forks source link

Modrinth requires "updating" and opening to Windows UAC upon every launch of the app #2453

Open tismelyla opened 2 months ago

tismelyla commented 2 months ago

Please confirm the following.

What version of the Modrinth App are you using?

0.8.7

What operating systems are you seeing the problem on?

No response

Describe the bug

Upon opening the app, Modrinth begins to check for updates, then it closes, request Windows UAC to make changes to my device. I let it, as I'd like to play Minecraft. However, after repeating this process several times the version number did not change. It stuck to v.0.8.7

Steps to reproduce

  1. Ensure Modrinth is closed.
  2. Open Modrinth
  3. Modrinth checks for updates
  4. Approve Windows UAC

Expected behavior

Modrinth checks for updates, checks I'm running the latest, then loads me into the app.

Additional context

No response

brawaru commented 2 months ago

Just to clarify the issue: you most likely have both 0.8.5 and 0.8.7 installed, and your shortcuts still point to and open 0.8.5 that automatically tries to update itself to 0.8.7 upon launch. To work around this for now, please try uninstalling all versions of Modrinth App through Windows Settings and then install the latest version from https://modrinth.com/app.

The team is aware of the issues with updating and planning to fix them in the next version. Since I cannot find any issues about the update not installing properly, it perhaps worth keeping this open until this is resolved.

Felix14-v2 commented 2 months ago

Since I cannot find any issues about the update not installing properly

The issue is not with broken installation — the launcher installs an update without any issues, but in a different location, C:\Program Files\Modrinth App, instead of the old one (%LocalAppData%\Modrinth App iirc). I wrote about this behavior even before the 0.8.0 release in the Modrinth Labs discord, but was ignored.

brawaru commented 2 months ago

I meant issues on GitHub :) The cause is kind of known, I believe it's because the app doesn't properly uninstall previous version, because it re-installs itself system-wide, whereas previous installation was for the current user (which it should've remained, really (#2386), but was changed supposedly to fix previous update), so you end up with two or three installations — 0.8.5 (user, NSIS), 0.8.7 (system, NSIS), 0.7.1 (system, MSI).