modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
898 stars 160 forks source link

Trying to install a mod's specific version in it's versions list will still pop-up the incompatibility warning #2473

Open RubenRME opened 4 days ago

RubenRME commented 4 days ago

Please confirm the following.

What version of the Modrinth App are you using?

v0.8.7

What operating systems are you seeing the problem on?

MacOS

Describe the bug

When going into the version tab on a specific mod that's not listed as being compatible with your current instance, and clicking the install (or switch version) button on a version, will cause the incompatibility warning to pop up rather than installing said version.

Steps to reproduce

  1. Go into instance
  2. Enable override loader
  3. Open mod that has a version for a different loader (e.g. fabric in a forge instance or vice versa)
  4. Click on "versions"
  5. Deselect the pre-selected filter (e.g. fabric/forge/neoforge)
  6. Click green install button next to a version with a different loader
  7. Observe

Expected behavior

The client installs that specific version into the instance; after all, you have already manually overridden the loader twice and clicked on a specific version.

Alternatively: the warning does pop up with the specific version selected and/or filtered list to choose from.

Additional context

https://github.com/user-attachments/assets/f94eba58-8780-4e8f-b569-d8d35c4c1e3c