search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Whether Fabric or Forge comes first in "featured versions" is inconsistent #2716

Closed quat1024 closed 2 years ago

quat1024 commented 2 years ago

Describe the bug If you have a mod available for the same Minecraft version on two modloaders, and manually feature both of them, it's not consistent whether the API chooses to report the Fabric or Forge one first.

It might be using something else to break ties, like file upload date or something. Not too familiar.

Since (I assume) the frontend shows featured versions in the order they are reported by the API, this manifests as "a kinda confusing download experience": if there are multiple Minecraft versions like this, they don't alternate.

To Reproduce Steps to reproduce the behavior:

  1. Create four files, covering every combination of "two minecraft versions" and "two modloaders".
  2. Feature them all.
  3. Sometimes the Fabric one comes first, sometimes the Forge one comes first. I can't tell what decides this.

Here is an affected project on the production site. On the featured versions list, Fabric comes first on 1.18.2, and Forge comes first on 1.18.1. (The project is using manual featuring, I toggled all the "featured" checkboxes myself.)

Additional context I was gonna report this on the frontend, but asked on discord and Geometrically told me to post it here.

triphora commented 2 years ago

...is it not sorted by upload date?

triphora commented 2 years ago

Closing as "won't fix" since it is just ordered by upload date, for reordering those still please refer to modrinth/knossos#307