search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
921 stars 171 forks source link

Notifications can't be dismissed #2756

Closed edwloef closed 3 years ago

edwloef commented 3 years ago

Issue: When I try to dismiss a notification of a mod being updated, the loading bar goes to the end of the screen and just stops. Upon reload the notification is still there.

Steps to reproduce the behavior:

  1. Go to the notifications window
  2. Try to delete a notification

Expected behavior: The loading bar goes to the end of the screen and the notification disappears.

Context: I am using Firefox on Windows 10

triphora commented 3 years ago

Duplicate of modrinth/code#1990. This is a frontend issue, not a backend one. It appears to be caused by 566833d, so if you wish to dismiss notifications, I've reverted that commit on my own branch at https://emma-knossos.vercel.app (but this is not a permanent fix; modrinth/code#2031 is unfixed on this branch)

edwloef commented 3 years ago

Ah, sorry, I wasn't aware.