modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
991 stars 187 forks source link

Possible bug in modpack exports #2870

Open tillhfm opened 3 weeks ago

tillhfm commented 3 weeks ago

Please confirm the following.

What version of the Modrinth App are you using?

v0.8.9

What operating systems are you seeing the problem on?

Windows, MacOS, Linux

Describe the bug

I'm not sure if this is incorrect behaviour - but to me it seems.

When exporting a modpack (either from the app or downloading one on the website) and you check the modrinth.index.json file, the env attributes server & client will always be set to required.

I noticed this because I tried to create a server from a modpack using mrpack-install. The server failed to start because it tried to load a lot of client-side mods which were installed by mrpack-install (probably because they have env.server set to required in modrinth.index.json).

example

Steps to reproduce

  1. Export a modpack as .mrpack or download one from Modrinth
  2. Open it as ZIP folder and open the file modrinth.index.js
  3. All mods will have env.server set to required.

Expected behavior

To me it seems like the env.server attribute should be set to something like not_required for mods that do not run on the server and thus the mrpack-install tool should not install mods into the server that can't be run.

Additional context

This is mostly assumptions. I'm new to Modrinth but it seems off that its so complicated to get a server running off your modpack.