modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
984 stars 187 forks source link

App doesn't sanitize file names from Modpacks #2925

Open Minenash opened 2 weeks ago

Minenash commented 2 weeks ago

Please confirm the following.

What version of the Modrinth App are you using?

0.8.9

What operating systems are you seeing the problem on?

Windows

Describe the bug

Files in zips/mrpack can contain letters not allowed by Windows (" for example). Windows's file-manager (or 7zip, not sure) handles this by replacing the characters that aren't valid in windows with an underscore.

The app doesn't do this, it tries to copy the file but since the path is invalid, it fails and the instantiation is aborted

Steps to reproduce

  1. Try to install the modpack Garry's Mod v1.13.0
  2. See copy error

Expected behavior

No response

Additional context

No response