modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
911 stars 166 forks source link

[BUG] Modpack (made using the app) installation on linux os #664

Closed QarthO closed 1 year ago

QarthO commented 1 year ago

Describe the bug

App problem uploading packs, then installing them on linux

I've created a modpack using the app, (exporting profile, then uploading it to the website It worked, I can see the pack, and install it. However my friend who's OS is linux, if he downloads the pack through the app, the instance doesnt have any mods in it. Looking into it, the folder of the instance has all the mods in the root directory and not inside the mod folder. Each jar file for the mods are named "mods/.jar". This naming convention works for windows OS, but not linux.

He then tried installing fabulously optimized modpack and that modpack worked. I'm assuming becasue that modpack wasnt made using the app. So my guess is there is some issue in the export profile logic.

If you'd like to test it (I can't because I dont have a linux computer)

Being on a Linux OS: Download any version of this modpack https://modrinth.com/modpack/qvanilla+ Then look at the instance (you'll see no mods are in it)

This issue might also exist on MacOS, I do have a mac, and can test it later today

Steps to reproduce

  1. Be on a linux OS
  2. Open the launcher
  3. Search and install this modpack: https://modrinth.com/modpack/qvanilla+
  4. Your instance will have no mods
  5. Open the instance's folder, you will see all the mods inside the root directory but have "mod/" in their name

Expected behavior

mods are put inside the mods folder when installing a modpack (only modpacks made with the app)) on linux os

Additional context

No response

QarthO commented 1 year ago

Duplicate of #595

Issue might also exist on MacOS not just linux