search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
903 stars 164 forks source link

Sort by Licenses #821

Open Camawama opened 11 months ago

Camawama commented 11 months ago

Is your suggested enhancement related to a problem? Please describe.

Unable to easily check all 260 mod licenses.

Describe the solution you'd like

I think everyone could benefit from a sort type for License. I have a ton of mods added in my modpack but just recently, we started worrying about license stuff, and checking all 260 mods manually is a process. If there was a "sort by license" option, I could easily narrow down mods that we could not use for our purposes.

Describe alternatives you've considered

Manually going through and checking the license on all 260 mods

Additional context

No response

triphora commented 11 months ago

Modrinth mods can be used in Modrinth modpacks regardless of license, and we don't have access to license data from mods outside the platform. So I'm not entirely sure how this would help.

Camawama commented 11 months ago

We are making a server which we will monetize (of course following the TOS) but there are probably some mods out there that might not be ok with us doing so. We won't be selling the modpack, but instead, selling cosmetics on the server which will have the mods installed.

Correct me if I'm wrong but couldn't this lead to trouble if we had a mod installed which did not have an Open Source license?

The cosmetics will be small things like colored chat.

triphora commented 11 months ago

Modrinth mods can be used in Modrinth modpacks, regardless of license. When uploading to Modrinth, the author explicitly grants this right to Modrinth as per our Terms.

Camawama commented 11 months ago

I just noticed that a lot of mods have different licenses despite being hosted on Modrinth. I want to be able to sort by those licenses, that's all...

triphora commented 11 months ago

I mean, the fact of the matter is that this is a case of the XY problem. You've suggested a solution that you think would work to solve the issue, but the true utility of this feature is yet to be seen. A license sort would not help you solve the issue you have at hand. If nobody is going to use something, where's the point in adding it?

Additionally, when it comes to implementation, what do you mean by "sort by license" in the first place? Providing a sort option wouldn't do anything except jumble the list in a different order, which is pointless when that info isn't even displayed in the mod list UI anyway.

I'm sorry if I'm coming off as harsh or abrasive, but we need to have a reason to justify the work needed to add something.

Camawama commented 11 months ago

You have a point with the list being in a different order. When searching for content to add into a modpack, there is already an Open Source checkbox. I am just hoping there could maybe be a way to add that little sort check into the current mod list so I could check which mods currently added are open source.

triphora commented 11 months ago

I can see that being useful, yes.