search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
929 stars 174 forks source link

Features extending instance hooks #952

Open PixelBedrock opened 10 months ago

PixelBedrock commented 10 months ago

Is your suggested enhancement related to a problem? Please describe.

Modrinth doesn't give any documentation towards the hooks for instances. My test script fails with error code 2 with zero logging from within the Modrinth app itself, except for the toast telling me it failed with error code 2.

Describe the solution you'd like

Some documentation towards the hooks and environment variables (or command line args) provided by Modrinth for the instance to use. I have provided some example images from MultiMC for reference towards what I would like to be added to Modrinth.

image

image

Describe alternatives you've considered

I have attempted to create a script that tells me what environment variables and command line arguments are available, but fails with error code 2 with zero explanation from the Modrinth app. The script works perfectly fine outside of Modrinth, but refuses to run and exits with error code 2 when used as a hook.

Additional context

N/A, all screenshots and context have been included above.

EchoEllet commented 4 months ago

That's usually because those environment variables might not be supported yet or have a different name than the other launchers.

Prospector commented 4 months ago

I believe the hooks in the Modrinth App currently don't support any variables, they're basically just triggers for running commands. They probably can be made more powerful in the future

EchoEllet commented 3 months ago

It seems that this feature request is already in the TODO list in code:

https://github.com/modrinth/code/blob/0f2ddb452cc3baeb85a9a9d1e00dc43ba6b1517d/packages/app-lib/src/api/profile/mod.rs#L780-L802