search

modrinth / code

The Modrinth monorepo containing all code which powers Modrinth!
https://modrinth.com
Other
975 stars 181 forks source link

MacOS Game mode support #968

Open K1kss opened 10 months ago

K1kss commented 10 months ago

Describe the bug

Hello, In MacOS there is a feature called game mode introduced in macOS Sonoma that lets you focus your computer hardware on a game, it activates automatically when you open a game and there is no manual way to activate it, Minecraft already has this on the official launcher, Modrinth launcher doesn't trigger this feature, it may be a problem related to the OS detecting Modrinth Minecraft as an app and not as a game, so it will be awesome for it to be fixed so MacOS users can the modpackt with the full capacity of the computer.

Steps to reproduce

  1. Open Modrinth
  2. Launch any modpack
  3. Set fullscreen
  4. Game mode function doesn't activate

Expected behavior

  1. Open Modrinth
  2. Launch any modpack
  3. Set fullscreen
  4. Game mode function activates successfully, computer cpu and gpu is focused on Minecraft

System information

MacOS Sonoma 14.2.1 MacBook M1 Pro 14-inch

Additional context

MacOS automatically triggers game mode when a game is set to fullscreen, the problem is about the OS not detecting Modrinth Minecraft as a game. When the feature was released Minecraft official launcher didn't activate the game mode but was added a few weeks after with a launcher update.

MbtMarco commented 1 week ago

Modrinth 8.9 didn't fix it, must game mode enable with java process not by the launcher