modrzew / hass-flashforge-adventurer-3

Home Assistant integration providing support for the FlashForge Adventurer 3 3D printer.
20 stars 10 forks source link

Works with Adventurer 4 (with modifications) #1

Closed brendann993 closed 1 year ago

brendann993 commented 1 year ago

Python is not my strong suit but I can confirm this appears to work with Adventurer 4 by adding a self.type == 'flashforge_adventurer_4' in the is_supported in sensor.py Adventurer 3 and Adventurer 4 basically talk the same way so its to be expected

modrzew commented 1 year ago

Hey there! Thanks for the report 🙂 looks like Adventurer 3 and Adventurer 4 talk with outside world in the same manner. Happy to add a mention about that in the readme.

By the way, the dropdown for choosing the printer model doesn't really do much, other than letting the user know that this piece of code was only tested with that specific printer. It's likely it could work with other models (as in your case), but it's also likely it wouldn't (as highlighted in #2).

terppatyyppi commented 1 year ago

Can anyone please help me in making my Av. 4 compatible with this integration? The first message here explains it, but I'm unable to find any such place in sensor.py ("is.supported"), so I have no idea where to add the mentioned declaration.

modrzew commented 1 year ago

Hey @terppatyyppi, I've removed the printer type dropdown from the integration since my last comment, so you should be able to just install it and use it without having to adjust any code. Let me know how it goes.

modrzew commented 1 year ago

(I'll close this issue for now since there's nothing else to do at the moment.)

terppatyyppi commented 1 year ago

Thank you so much!

roperstv commented 1 year ago

This hacs worked straight out of the box for me using a Av. 4, entities/sub it seems to support are as follows

Progress however results in reporting a 0, would be nice to be able to see the actual progress.

Thanks for building this mod. useful!

Sereen666 commented 1 year ago

Adventurer 3 works out of the box. Adventurer 4 took a bit of loading time but does work (however i changed the entity names to show that it is the Adventurer 4) <-- Adventuerer 4 camera and status do work but the progress won't update -->

Many thanks for this integration tho! Would be awsome if i could also manage the lights and such but this far verry happy!

Happy to test stuff if needed (i know a bit of programming), many thanks again!