search

modrzew / hass-flashforge-adventurer-3

Home Assistant integration providing support for the FlashForge Adventurer 3 3D printer.
21 stars 12 forks source link

Fixing reply_regex to match current response #12

Open darek-margas opened 2 years ago

darek-margas commented 2 years ago

This fixes lack of progress, possibly caused by newer firmware

modrzew commented 2 years ago

Hey @darek-margas, thanks for the PR. Can you tell me which printer and which firmware this is specifically for? I saw your comment in another issue mentioning a new firmware version which started returning information about layers.

My Adventurer 3 is on the newest 1.3.6 firmware, and the response after sending ~M27 is still the same as before:

CMD M27 Received.
SD printing byte 2/100
ok

meaning this PR would fix it for a different printer but would also break it for Adventurer 3. I'm happy to make this integration more compatible, but with maintaining backwards compatibility and ensuring it works on Adventurer 3.

Can you tell me which printer are you using and with which firmware version?

modrzew commented 2 years ago

Hey @darek-margas, thanks for helping with solving this issue! I opted for a slightly different approach in af60c8c2b150f6a2f6fe9659069397a2eb75c95b which makes it compatible with both Adventurer 3 and 4. Let me know if it works for you 🙂