modrzew / pokeminer

Pokemon location scraper
MIT License
219 stars 61 forks source link

[suggestion] Different leaflet Basemap provider #186

Open YonderGod opened 8 years ago

YonderGod commented 8 years ago

My issue with the current (I assume default) map on leaflet is that it doesn't highlight all of the major streets, making it hard to quickly see approximately where a pokemon is or quickly find my current location.

Is it just me, or do others have the same problem?

http://leafletjs.com/plugins.html#basemap-providers

Preview here: http://leaflet-extras.github.io/leaflet-providers/preview/

I suggest: HERE.normalDay or Esri.WorldStreetMap

theresthatguy commented 8 years ago

World Street Map looks nice.

modrzew commented 8 years ago

I used the default one because it doesn't require any API key, and I didn't find the demo page you posted at the time. And it's been working fine for me (though it's ugly).

Let me look at them when I have a minute. In the meantime, you can switch the URL in newmap.html.

YonderGod commented 8 years ago

To use a different basemap, read https://developers.arcgis.com/terms/ and register an account Then in /templates/newmap.html replace line L.tileLayer('http://{s}.tile.osm.org/{z}/{x}/{y}.png', {opacity: 0.5}).addTo(map); with L.tileLayer('//server.arcgisonline.com/ArcGIS/rest/services/World_Street_Map/MapServer/tile/{z}/{y}/{x}', {opacity: 0.5}).addTo(map);