search

modrzew / pokeminer

Pokemon location scraper
MIT License
220 stars 62 forks source link

FIX to db engine poolclass #193

Closed Aiyubi closed 8 years ago

Aiyubi commented 8 years ago

due to other defaults in newer SQL alchemy versions the poolclass needs to be set explicitly Fix for #192

modrzew commented 8 years ago

I think this may degrade MySQL performance, which by default uses pool of connections.

Moreover, from SQLAlchemy docs:

SingletonThreadPool may be improved in a future release, however in its current status it is generally used only for test scenarios using a SQLite :memory: database and is not recommended for production use.

Moreover 2, SQLite related problems should disappear once DatabaseProcessor from coroutines lands in master.