Binmapping of single ping data

modscripps / velosearaptor

python ADCP routines

https://modscripps.github.io/velosearaptor

GNU General Public License v3.0

8 stars 3 forks source link

Binmapping of single ping data #17

Closed jessecusack closed 2 years ago

jessecusack commented 2 years ago

This is very much a work in progress to address #8.

To do:

[x] Implement a method to process single ping data
[x] Apply edits to the single ping processing (correlation, error vel etc.)
[x] Apply bin mapping into the single ping processing
[x] Write unit tests with a small data file

Comments/questions:

Why are amplitude data averaged over beams?
Writing tgridparams and dgridparams to the logger doesn't make sense if they're not used.

gunnarvoet commented 2 years ago

Do you want to merge this into main or keep developing for a bit in here? Maybe the latter for now as it is easy for me tho pull this branch and look into it if you want any input?

I can get to your questions re amplitude averaging and logging later this week. I just wanted to note that I started some rudimentary unit testing with a couple small data files. You could add your file as a case that needs bin mapping.

jessecusack commented 2 years ago

I was thinking of finishing off the to do list before merging. I'll throw in some data for the unit testing.

jessecusack commented 2 years ago

Hey @gunnarvoet, I think the PR is good to go. Want to give it a quick look over first?

gunnarvoet commented 2 years ago

Yes, happy to take a look!

jessecusack commented 2 years ago

Hey @gunnarvoet, I changed the way meta data is added. I think this pull request is ready to merge.