Open jessecusack opened 2 years ago
I found myself looking at the influence of various processing parameters on individual pings in the past and think your idea could really help make it easier to identify the impacts of whatever processing parameters one chooses, and also to quickly change them. Similar to what I mentioned in #15, I am not quite sure yet how this would work for datasets but will take a look and think about it. Generally I vote for this change!
Currently, edits are made by masking the
xyze
data using several different QC thresholds, while information about the QC state for any given threshold is not stored. I think it would be better if we defined some variables likeflag_cor
andflag_vel
etc. to store the quality control info. The final mask would then be logical OR of all the flags. This will make it easier to add more flags in the future (e.g.flag_fish
orflag_ice
). The individual flags could then be used to define abad_beam
which will be fed into a 3 beam solution function (#18).@gunnarvoet, what do you think about changing the whole idea of edit to quality control instead? So the
editparams
dict would becomeQCparams
, or something like that. Then there could be a function calledapply_QC
which actually does the editing, when needed, with separate methods for generating flags.