search

modscripps / velosearaptor

python ADCP routines
https://modscripps.github.io/velosearaptor
GNU General Public License v3.0
8 stars 3 forks source link

Add style checks to Makefile #33

Closed jessecusack closed 2 years ago

jessecusack commented 2 years ago

Addresses #32.

I copy-pasted the style checking code from mixsea to here and ran it. I also updated environment.yml to include black, isort and flake8.

This PR is based off #17, so we should merge that one first.

gunnarvoet commented 2 years ago

Thanks for adding this to the package!

jessecusack commented 2 years ago

Once #17 is merged I think this one can be merged too

gunnarvoet commented 2 years ago

Do we need to merge with the updated main after merging #17?

jessecusack commented 2 years ago

Oh, there are conflicts. I guess I don't understand quite how this process works. Let me try and fix it.

gunnarvoet commented 2 years ago

Sounds good! I also added you as a collaborator so you can merge this yourself if you'd like!

On Tue, May 24, 2022 at 7:34 AM Jesse Cusack @.***> wrote:

Oh, there are conflicts. I guess I don't understand quite how this process works. Let me try and fix it.

— Reply to this email directly, view it on GitHub https://github.com/gunnarvoet/gadcp/pull/33#issuecomment-1136011391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7F5ZMELOYC6YRCPVXSVZDVLTSINANCNFSM5WJRUE6Q . You are receiving this because you commented.Message ID: @.***>