Closed sleweke-bayer closed 1 week ago
Maybe we could figure out how to do that on the unit-operation level. Then, finite volume discretizations can still do the full Newton.
Update:
IDAS_TOO_MUCH_WORK
for all transport models. By setting MAX_STEPS
higher and higher, the simulations finally terminate but with excessive compute times. I have no explanation for this rn, full Newton simply being that much more efficient here is counter intuitive for me. Any ideas on that?As it is right now, we need to make the modified/full Newton optional, with default to the latter if sensitivities are involved.
- Sensitivities might work better with the full Newton method.
I've noticed that the Jacobian was not evaluated when residualSens()
was called.
This is now fixed, please test again.
Changes from full Newton to modified Newton in the time integrator. The Jacobian is only updated when SUNDIALS requests us to. This enables us to reuse the factorized Jacobian for multiple linear solves.
TODO