modsim / FluxML

A Universal Modeling Language for Metabolic Flux Analysis
MIT License
9 stars 6 forks source link

Input pools can not be named like a flux #16

Closed mbeyss closed 2 years ago

mbeyss commented 2 years ago

Otherwise an error is raised

FluxML parsing error: input pool "XXX" specified in equality constraint

or

FluxML parsing error: input pool "XXX" specified in inequality constraint

This originates in fluxml/FluxMLInput.cc, where all equality/inequality constraints are checked for input pool names. It should only be equality constraints for pools.

I would argue, that it is bad practice to have fluxes and pools of the same name, nonetheless this should be fixed.

also: In the error the actual constraint should be printed

mbeyss commented 2 years ago

fixed