modubot / modubot.js

Modubot: the scalable and extensible IRC bot.
https://modubot.net
BSD 3-Clause "New" or "Revised" License
19 stars 3 forks source link

Process.title #55

Closed ghost closed 8 years ago

ghost commented 9 years ago

Add a config option for naming the bot and use a lowercase version of that name for the process.title in nodejs

kamaln7 commented 8 years ago

@alexkavon does #59 work?

ghost commented 8 years ago

That works, however I was thinking of something like:

config.yml

name: modubot

Bot.ts

process.title = this.config.name

Or something....

kamaln7 commented 8 years ago

That would be one more config option that you'll need to edit. I think irc server + nick should be unique enough. +@reynir thoughts?

reynir commented 8 years ago

I would use either just the nick, or possibly the realname. I can't really think of a situation where you wouldn't want it to be one of those.

kamaln7 commented 8 years ago

Cool. The server is there just so you can differentiate between the different processes if you have a Modubot instance with the same nick connected to two+ different servers.

ghost commented 8 years ago

or in Bot.ts

process.title = this.config.name || 'modubot';

kamal_ learn 2 default configs pl0x

kamaln7 commented 8 years ago

https://github.com/modubot/modubot.js/tree/master/config

Modubot falls back the default config file if a key is missing from the config.yml file. Why are we still discussing this?

ghost commented 8 years ago

k

ghost commented 8 years ago

Your PR looks good then.

kamaln7 commented 8 years ago

Merged #59