search

modul-is / orm

Simple lightweight ORM
12 stars 0 forks source link

I suggest not deprecate for findAll() method #9

Closed SlavaAurim closed 2 years ago

SlavaAurim commented 2 years ago

Hi! This is a great project and a beautiful continuation of life for YetORM! I am currently mastering v2 with PHP 8.

I would like to ask you not to delete the Repository::findAll method because it seems to me a very logical and elegant abstraction. Specific repositories may eventually hide their logic for default filters in it (for example, ['active'= > true, deleted=> 'false']), but for now if this is not necessary - use the basic finAll(). And to find realy all records - use finBy([]).

kravcik commented 2 years ago

Currently we working on new version. Plan was delete findAll in final release, that is reason why this function was deprecated.

But I think this abstraction can stay.

Thanks for suggestion!