There is a perhaps corner case where
exec/try_exec use system
and q_exe uses Process.Create
system probably always uses sh
Process.Create uses sh in a fallback, depending on error.
Cygwin system is finding git
Cygwin Process.Create is not finding git
I am guessing there is rarely a difference?? But I don't know.
In my case, git.exe is the Windows git and I have no Cygwin git.
Installing Cygwin git could help.
The rest of the build create a lot of processes and works.
"For now", maybe forever, in version.quake, skip running git on Cygwin.
Probably nobody will notice.
I looked into changing Process.Create to fallback for another error (NOENT)
to /bin/sh. That should "fix" it. But not clear we should make that change there.
There is Cygwin-specific Process.Create (could be at runtime anyway).
Maybe at the Quake layer we should do something, or in sysutils.
But anyway "for now" this isn't terrible. No other system has needed
a change here in a very long time. Cygwin-specific work isn't very valuable
esp. for this one? thing.
There is a perhaps corner case where exec/try_exec use system and q_exe uses Process.Create
system probably always uses sh Process.Create uses sh in a fallback, depending on error.
Cygwin system is finding git Cygwin Process.Create is not finding git
I am guessing there is rarely a difference?? But I don't know. In my case, git.exe is the Windows git and I have no Cygwin git. Installing Cygwin git could help.
The rest of the build create a lot of processes and works.
"For now", maybe forever, in version.quake, skip running git on Cygwin. Probably nobody will notice.
I looked into changing Process.Create to fallback for another error (NOENT) to /bin/sh. That should "fix" it. But not clear we should make that change there. There is Cygwin-specific Process.Create (could be at runtime anyway).
Maybe at the Quake layer we should do something, or in sysutils.
But anyway "for now" this isn't terrible. No other system has needed a change here in a very long time. Cygwin-specific work isn't very valuable esp. for this one? thing.