modularml / max

A collection of sample programs, notebooks, and tools which highlight the power of the MAX Platform
https://www.modular.com
Other
322 stars 41 forks source link

[BUG]: Cannot visualise an onnx model with Sub operand #142

Closed katrasnikj closed 2 months ago

katrasnikj commented 5 months ago

Bug description

When trying to visualise an onnx model I get the following error:

error: 'mo.sub' op requires the same type for all operands and results

The node looks like this: image

Steps to reproduce

max visualize model.onnx

System information

modular 0.7.0 (487c2f88)
ehsanmok commented 5 months ago

Thanks for reporting! what version of max -v are you using?

katrasnikj commented 5 months ago

max 24.2.0 (c2427bc5) Modular version 24.2.0-c2427bc5-release

ehsanmok commented 5 months ago

Thank you! could you share more about what type of model is having this issue and perhaps provide a reproducing example?

iamtimdavis commented 2 months ago

@katrasnikj - please let us know if you are facing issues and re-open this ticket, otherwise please try in 24.4. Thanks!