modularml / mojo

The Mojo Programming Language
https://docs.modular.com/mojo/manual/
Other
22.92k stars 2.58k forks source link

[Modular CLI] Include mojo version in Max --version #3109

Open DWSimmons opened 2 months ago

DWSimmons commented 2 months ago

Issue description

I don't believe everyone knows that mojo underpins max. Instead of

darin@home:~$ max --version
max 2024.6.1505 (238bad6d)
Modular version 2024.6.1505-238bad6d-release

I think it should read

darin@home:~$ max --version
max 2024.6.1505 (238bad6d)
**mojo 2024.6.1505 (238bad6d)**
Modular version 2024.6.1505-238bad6d-release

Would be more explicit, remind people that mojo is there and ready. Also, I've heard that installing both nightly/max and nightly/mojo is not best-practice. Declaring that mojo is installed and update might discourage installing nightly/mojo (or stable).

Steps to reproduce

Version Info

- Provide Modular CLI version by pasting the output of `modular -v`
modular 0.8.0 (39a426b5)
- What OS did you install modular CLI on ?
Description:    Ubuntu 22.04.4 LTS
DWSimmons commented 1 month ago

I noticed a change in installing nightly/max returns

max --version
max 2024.7.1505 (ba28802f)
Modular version 2024.7.1505-ba28802f-release

Isn't Modular the CLI tool and that the nightly version is mojo ? I would imagine it would like like

max --version
max 2024.7.1505 (ba28802f)
mojo  version 2024.7.1505-ba28802f-release
modular 0.8.0 (39a426b5)

or no modular line.