Closed laszlokindrat closed 3 months ago
hello @laszlokindrat , just wanted to let you know that I pushed a couple of PRs to address the tasks in this issue: #3214 , #3216 and #3221
This is now complete thanks to @MatveyF, @vguerra, and @martinvuyk! 🎉
I actually had nothing to do with this lol, just pushed a commit that referenced this during a rebase. Anyhow great work :D
The following types are missing tests for the operators required by the
Comparable
trait (__le__
,__ge__
, etc.):Int
: done in https://github.com/modularml/mojo/pull/3161IntLiteral
: done in https://github.com/modularml/mojo/pull/3214FloatLiteral
: done in https://github.com/modularml/mojo/pull/3216SIMD
: done in https://github.com/modularml/mojo/pull/3221We should also ensure they have tests for
__eq__
and__ne__
. Keep in mind that dunder methods should be tested directly (i.e. not through operator syntax sugar) for these basic numeric types to avoid unintended implicit conversions.: